Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing awaits corrupt project.pbxproj #612

Open
xShuusui opened this issue Nov 7, 2024 · 1 comment
Open

Missing awaits corrupt project.pbxproj #612

xShuusui opened this issue Nov 7, 2024 · 1 comment
Labels

Comments

@xShuusui
Copy link

xShuusui commented Nov 7, 2024

ℹ️ Info

Version: 0.14.1 and 0.13.1

💬 Description

When running dart run flutter_launcher_icons to generate launcher icons for each of our flavors, the project.pbxproj file of iOS is frequently corrupted and the ASSETCATALOG_COMPILER_APPICON_NAME values for the different flavor targets are not set correctly.

This issue occurs due to asynchronous read and write operations on the project.pbxproj for each flavor that are not awaited correctly, leading to simultaneous execution. As a result, the file becomes incorrect and corrupted.

Related Issues:
#506
#550
#565

A pull request will be opened in the coming days to address this issue. Afterward, a decision can be made on whether to proceed with the fixed asynchronous approach or to use the synchronous approach suggested in PR #551.

@tmenyhart-vlabs
Copy link

There's an open PR that should resolve the issue.

The issue is because the following line in the ios.dart file:

line.contains('ASSETCATALOG')) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants