feat: alert on rollback when canary not ready

rvanoo · rvanoo · commit 00892a35f383 · 2025-07-29T13:31:29.000-04:00
Signed-off-by: Rob van Oostrum &lt;rvanoo@gmail.com&gt;
diff --git a/pkg/controller/scheduler.go b/pkg/controller/scheduler.go
@@ -347,6 +347,8 @@ func (c *Controller) advanceCanary(name string, namespace string) {
 	if err != nil {
 		c.recordEventWarningf(cd, "%v", err)
 		if !retriable {
+			c.recordEventWarningf(cd, "Rolling back %s.%s canary not ready", cd.Name, cd.Namespace)
+			c.alert(cd, "Rolling back canary not ready", false, flaggerv1.SeverityError)
 			c.rollback(cd, canaryController, meshRouter, scalerReconciler)
 		}
 		return

Original file line number	Diff line number	Diff line change
`@@ -347,6 +347,8 @@ func (c *Controller) advanceCanary(name string, namespace string) {`
`347`	`347`	`if err != nil {`
`348`	`348`	`c.recordEventWarningf(cd, "%v", err)`
`349`	`349`	`if !retriable {`
	`350`	`+ c.recordEventWarningf(cd, "Rolling back %s.%s canary not ready", cd.Name, cd.Namespace)`
	`351`	`+ c.alert(cd, "Rolling back canary not ready", false, flaggerv1.SeverityError)`
`350`	`352`	`c.rollback(cd, canaryController, meshRouter, scalerReconciler)`
`351`	`353`	`}`
`352`	`354`	`return`