Add tests for matchLabels behavior

Tests the `matchLabels` behavior for `Deployment`, `DaemonSet`, and `Service`

Signed-off-by: Kevin Snyder <[email protected]>

Author: KevinSnyderCodes

pkg/canary/daemonset_controller_test.go

@@ -72,6 +72,21 @@ func TestDaemonSetController_Sync_InconsistentNaming(t *testing.T) {
 	assert.Equal(t, primarySelectorValue, fmt.Sprintf("%s-primary", sourceSelectorValue))
 }
 
+func TestDaemonSetController_Initialize(t *testing.T) {
+	dc := daemonsetConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
+	mocks := newDaemonSetFixture(dc)
+	_, err := mocks.controller.Initialize(mocks.canary)
+	require.NoError(t, err)
+
+	daePrimary, err := mocks.kubeClient.AppsV1().DaemonSets("default").Get(context.TODO(), "podinfo-primary", metav1.GetOptions{})
+	require.NoError(t, err)
+
+	daePrimaryMatchLabels := daePrimary.Spec.Selector.MatchLabels
+	assert.Equal(t, 2, len(daePrimaryMatchLabels))
+	assert.Equal(t, "podinfo-primary", daePrimaryMatchLabels["name"])
+	assert.Equal(t, "test-label-value-1", daePrimaryMatchLabels["test-label-1"])
+}
+
 func TestDaemonSetController_Promote(t *testing.T) {
 	dc := daemonsetConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
 	mocks := newDaemonSetFixture(dc)

pkg/canary/daemonset_fixture_test.go

@@ -379,7 +379,8 @@ func newDaemonSetControllerTestPodInfo(dc daemonsetConfigs) *appsv1.DaemonSet {
 		Spec: appsv1.DaemonSetSpec{
 			Selector: &metav1.LabelSelector{
 				MatchLabels: map[string]string{
-					dc.label: dc.labelValue,
+					dc.label:       dc.labelValue,
+					"test-label-1": "test-label-value-1",
 				},
 			},
 			Template: corev1.PodTemplateSpec{

pkg/canary/deployment_controller_test.go

@@ -69,6 +69,20 @@ func TestDeploymentController_Sync_InconsistentNaming(t *testing.T) {
 	assert.Equal(t, primarySelectorValue, fmt.Sprintf("%s-primary", dc.labelValue))
 }
 
+func TestDeploymentController_Initialize(t *testing.T) {
+	dc := deploymentConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
+	mocks := newDeploymentFixture(dc)
+	mocks.initializeCanary(t)
+
+	depPrimary, err := mocks.kubeClient.AppsV1().Deployments("default").Get(context.TODO(), "podinfo-primary", metav1.GetOptions{})
+	require.NoError(t, err)
+
+	depPrimaryMatchLabels := depPrimary.Spec.Selector.MatchLabels
+	assert.Equal(t, 2, len(depPrimaryMatchLabels))
+	assert.Equal(t, "podinfo-primary", depPrimaryMatchLabels["name"])
+	assert.Equal(t, "test-label-value-1", depPrimaryMatchLabels["test-label-1"])
+}
+
 func TestDeploymentController_Promote(t *testing.T) {
 	dc := deploymentConfigs{name: "podinfo", label: "name", labelValue: "podinfo"}
 	mocks := newDeploymentFixture(dc)

pkg/canary/deployment_fixture_test.go

@@ -430,7 +430,8 @@ func newDeploymentControllerTest(dc deploymentConfigs) *appsv1.Deployment {
 		Spec: appsv1.DeploymentSpec{
 			Selector: &metav1.LabelSelector{
 				MatchLabels: map[string]string{
-					dc.label: dc.labelValue,
+					dc.label:       dc.labelValue,
+					"test-label-1": "test-label-value-1",
 				},
 			},
 			Template: corev1.PodTemplateSpec{

pkg/router/kubernetes_default_test.go

@@ -40,6 +40,12 @@ func TestServiceRouter_Create(t *testing.T) {
 		kubeClient:    mocks.kubeClient,
 		flaggerClient: mocks.flaggerClient,
 		logger:        mocks.logger,
+		matchLabels: map[string]string{
+			"name":         "podinfo",
+			"test-label-1": "test-label-value-1",
+		},
+		labelSelector: "name",
+		labelValue:    "podinfo",
 	}
 	appProtocol := "http"
 
@@ -52,13 +58,20 @@ func TestServiceRouter_Create(t *testing.T) {
 	canarySvc, err := mocks.kubeClient.CoreV1().Services("default").Get(context.TODO(), "podinfo-canary", metav1.GetOptions{})
 	require.NoError(t, err)
 
+	assert.Equal(t, 2, len(canarySvc.Spec.Selector))
+	assert.Equal(t, "podinfo", canarySvc.Spec.Selector["name"])
+	assert.Equal(t, "test-label-value-1", canarySvc.Spec.Selector["test-label-1"])
 	assert.Equal(t, &appProtocol, canarySvc.Spec.Ports[0].AppProtocol)
 	assert.Equal(t, "http", canarySvc.Spec.Ports[0].Name)
 	assert.Equal(t, int32(9898), canarySvc.Spec.Ports[0].Port)
 	assert.Equal(t, "None", canarySvc.Spec.ClusterIP)
 
 	primarySvc, err := mocks.kubeClient.CoreV1().Services("default").Get(context.TODO(), "podinfo-primary", metav1.GetOptions{})
 	require.NoError(t, err)
+
+	assert.Equal(t, 2, len(primarySvc.Spec.Selector))
+	assert.Equal(t, "podinfo-primary", primarySvc.Spec.Selector["name"])
+	assert.Equal(t, "test-label-value-1", primarySvc.Spec.Selector["test-label-1"])
 	assert.Equal(t, "http", primarySvc.Spec.Ports[0].Name)
 	assert.Equal(t, int32(9898), primarySvc.Spec.Ports[0].Port)
 	assert.Equal(t, "None", primarySvc.Spec.ClusterIP)