Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux push artifact --ignore-paths should be added on top of the defaults #5144

Open
1 task done
matheuscscp opened this issue Jan 12, 2025 · 0 comments
Open
1 task done
Labels
area/oci OCI related issues and pull requests enhancement New feature or request

Comments

@matheuscscp
Copy link
Member

matheuscscp commented Jan 12, 2025

Describe the bug

The default ignore paths are very useful for most cases:

var excludeOCI = append(strings.Split(sourceignore.ExcludeVCS, ","), strings.Split(sourceignore.ExcludeExt, ",")...)

.git/,.gitignore,.gitmodules,.gitattributes,*.jpg,*.jpeg,*.gif,*.png,*.wmv,*.flv,*.tar.gz,*.zip

I don't want to re-specify all of them when using the --ignore-paths, I want to add more ignore paths on top of them.

Not using these defaults must still be supported somehow, but adding paths on top of the defaults would be very useful.

Steps to reproduce

flux push artifact --ignore-paths=some/path ...

Expected behavior

I don't want to re-specify all of them when using the --ignore-paths, I want to add more ignore paths on top of them.

Screenshots and recordings

No response

OS / Distro

N/A

Flux version

v2.4.0

Flux check

N/A

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@matheuscscp matheuscscp changed the title flux push artifact --ignore-paths should be added on top of the default flux push artifact --ignore-paths should be added on top of the defaults Jan 12, 2025
@matheuscscp matheuscscp added enhancement New feature or request area/oci OCI related issues and pull requests labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oci OCI related issues and pull requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant