Handle custom library crate-type

Closes GH-54.

Author: fmdkdd

flycheck-rust.el

@@ -38,11 +38,14 @@
 
 ;;; Code:
 
+(eval-when-compile
+  (require 'pcase)
+  (require 'let-alist))
+
 (require 'dash)
 (require 'flycheck)
 (require 'seq)
 (require 'json)
-(require 'let-alist)
 
 (defun flycheck-rust-find-manifest (file-name)
   "Get the Cargo.toml manifest for FILE-NAME.
@@ -146,7 +149,26 @@ description of the conventional Cargo project layout."
                                             (file-name-directory manifest)))))
             ;; If all else fails, just pick the first target
             (car targets))))
-      (let-alist target (cons (car .kind) .name)))))
+      (let-alist target (cons (flycheck-rust-normalize-target-kind .kind) .name)))))
+
+(defun flycheck-rust-normalize-target-kind (kinds)
+  "Return the normalized target name from KIND.
+
+KIND is a list of target name as returned by `cargo metadata',
+which do not necessarily correspond to to target names that can
+be passed as argument to `cargo rustc'.
+
+The normalization returns a valid cargo target based on KINDS."
+  ;; Assumption: we only care about the first kind name.  Multiple kinds only
+  ;; seem to happen for library crate types, and those all maps to the same
+  ;; `lib' target.
+  (pcase (car kinds)
+    (`"dylib" "lib")
+    (`"rlib" "lib")
+    (`"staticlib" "lib")
+    (`"cdylib" "lib")
+    (`"proc-macro" "lib")
+    (_ (car kinds))))
 
 ;;;###autoload
 (defun flycheck-rust-setup ()

tests/custom-lib-target/Cargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "custom-lib-target"
+version = "0.1.0"
+
+[lib]
+name = "foo"
+crate-type = ["dylib", "cdylib"]

tests/custom-lib-target/src/lib.rs

@@ -0,0 +1,6 @@
+#[cfg(test)]
+mod tests {
+    #[test]
+    fn it_works() {
+    }
+}

tests/test-rust-setup.el

@@ -35,6 +35,9 @@
 (defun crate-file (file-name)
   (expand-file-name file-name "tests/test-crate"))
 
+(defun lib-crate-file (file-name)
+  (expand-file-name file-name "tests/custom-lib-target"))
+
 (describe
  "`flycheck-rust-find-cargo-target' associates"
 
@@ -107,4 +110,9 @@
      (expect
       (flycheck-rust-find-cargo-target (crate-file "benches/support/mod.rs"))
       :to-equal-one-of '("bench" . "a") '("bench" . "b")))
+
+ (it "'src/lib.rs' to the library target"
+     (expect
+      (car (flycheck-rust-find-cargo-target (lib-crate-file "src/lib.rs")))
+      :to-equal "lib"))
  )