You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Part of #7445. Depends on #7446 (the /metrics endpoint + Scope must exist first).
Summary
Add Prometheus metrics to the runs service background reconcilers (starting with the abort reconciler) to observe queue depth, processing throughput, retries, and failures.
Background
runs/service/abort_reconciler.go runs as a background worker (registered in runs/setup.go via sc.AddWorker("abort-reconciler", ...)). It has a worker pool, a bounded queue (QueueSize: 1000), and retry logic (MaxAttempts, InitialDelay, MaxDelay). None of this is currently observable via metrics.
Summary
Add Prometheus metrics to the runs service background reconcilers (starting with the abort reconciler) to observe queue depth, processing throughput, retries, and failures.
Background
runs/service/abort_reconciler.goruns as a background worker (registered inruns/setup.goviasc.AddWorker("abort-reconciler", ...)). It has a worker pool, a bounded queue (QueueSize: 1000), and retry logic (MaxAttempts,InitialDelay,MaxDelay). None of this is currently observable via metrics.What to do
Scope(from [flyte2] Add /metrics endpoint and initialize metrics Scope in the app framework #7446) intoservice.NewAbortReconciler(...)(extend its config/constructor).Acceptance criteria
/metricsexposes abort-reconciler queue depth, processed count (success/failure), retry count, and processing latency.scope.NewSubScope("abort_reconciler"), created once.Pointers
runs/service/abort_reconciler.go— the reconciler implementation and its run loop.runs/setup.go:64-73— whereNewAbortReconcileris constructed and registered as a worker.flytestdlib/promutils/scope.go—Scopehelpers (MustNewGauge,MustNewCounter,MustNewStopWatch,NewSubScope).Notes for contributors
Scopefrom [flyte2] Add /metrics endpoint and initialize metrics Scope in the app framework #7446.