-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skill can't find any music #149
Comments
Hi, sadly Spotify disabled the API access for this skill. It violated their Terms of Service, it's apparently not OK to make a voice integration for Spotify without their written approval. I missed this when I set up the skill back in 2017 (or maybe it was added afterwards), sorry for the inconvenience. I've tried to contact them for approval but without getting anywhere. I will try to make it possible for people to supply their own api keys but it will have to wait a short while. |
Hi @forslund , I tried to understand your code concerning the API..If I understood spotipy and the authorization guide of spotify correctly, one needs an App authorization to use the API of spotify. Looking at spotipy and your code, you seem to provide "dev_cred" to obtain a token for the API access to spotify..correct? Is this a mycroft-wide dev-token for spotify? Or is it something else? Thanks |
Mycroft has an "oauth cred store" which the spotify skill uses. I plan on adding support for the normal spotipy auth scheme allowing users to create keys themselves You should be able to change 273-274 to be something like from spotipy.oauth2 import SpotifyClientCredentials
self.spotify = SpotifyConnect(client_credentials_manager=SpotifyClientCredentials()) and it should use the env variables. (this is all theoretical I've just begun looking at implementing it (again...back in 2017 I had code for this) |
Thanks, I look forward to it :) PS: If I can help in any way, just let me know. |
If you test and get something going, make a pull request :) Apart from that some usability tests will definitely be needed |
Ah well... Thanks for the quick reply @forslund. I wish I had time to offer support but wth my current situation that's a non-starter. |
Skill can't find any music
Hi there, hope you can help me with this. Maybe it's a bug with you, maybe with MyCroft?
Skill worked until this morning. Have it installed via PiCroft. SSH'd into box for some reason (I don't quite remember) and MyCroft autoupdated. Now Spotify is broken. It was really my favorite part about this voice assistant.
Here's the log when I search for Tom Petty.
Also of note. Installed Pandora since I figured it was worth a try while yours was down:
The text was updated successfully, but these errors were encountered: