Skip to content

Commit 20db51d

Browse files
rahul31124AsCress
authored andcommitted
Hardcoded dimensions
Hardcoded dimensions
1 parent 88b70f4 commit 20db51d

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

app/src/main/res/layout/fragment_gyroscope_data.xml

+7-7
Original file line numberDiff line numberDiff line change
@@ -17,25 +17,25 @@
1717
android:id="@+id/gyroscope_x_axis_fragment"
1818
android:name="io.pslab.fragment.GyroscopeViewFragment"
1919
android:layout_width="match_parent"
20-
android:layout_height="300dp"
21-
android:layout_margin="5dp"
20+
android:layout_height="@dimen/gyroscope_fragment_height"
21+
android:layout_margin="@dimen/gyroscope_fragment_margin"
2222
tools:layout="@layout/gyroscope_list_item" />
2323

2424
<fragment
2525
android:id="@+id/gyroscope_y_axis_fragment"
2626
android:name="io.pslab.fragment.GyroscopeViewFragment"
2727
android:layout_width="match_parent"
28-
android:layout_height="300dp"
29-
android:layout_margin="5dp"
28+
android:layout_height="@dimen/gyroscope_fragment_height"
29+
android:layout_margin="@dimen/gyroscope_fragment_margin"
3030
tools:layout="@layout/gyroscope_list_item" />
3131

3232
<fragment
3333
android:id="@+id/gyroscope_z_axis_fragment"
3434
android:name="io.pslab.fragment.GyroscopeViewFragment"
3535
android:layout_width="match_parent"
36-
android:layout_height="300dp"
37-
android:layout_margin="5dp"
36+
android:layout_height="@dimen/gyroscope_fragment_height"
37+
android:layout_margin="@dimen/gyroscope_fragment_margin"
3838
tools:layout="@layout/gyroscope_list_item" />
3939

4040
</LinearLayout>
41-
</ScrollView>
41+
</ScrollView>

app/src/main/res/values/dimens.xml

+3
Original file line numberDiff line numberDiff line change
@@ -421,4 +421,7 @@
421421
<dimen name="text_size_osc">13sp</dimen>
422422
<dimen name="text_size_9sp">9sp</dimen>
423423

424+
<dimen name="gyroscope_fragment_height">300dp</dimen>
425+
<dimen name="gyroscope_fragment_margin">5dp</dimen>
426+
424427
</resources>

0 commit comments

Comments
 (0)