-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Swift 5 Migration #560
Conversation
@chashmeetsingh, @jogendra, Please Review the PR. |
@jogendra, after migrating to swift 5.0, the project is not building due to JI pod failure, as JI pod is not updated for swift 5.0. |
@jogendra, the project is building now by manually making changes in JI and Readabilitykit pod files. Any idea of how to make a permanent change in these pods? |
@baquer If the pod is not in use, remove the Pod or find the good alternative. Otherwise, make a pull request to made changes in pod. The other thing we could do is make a fork to our org and make changes and use it but this is not the good way and I am not sure we will fork other repo in our org. @mariobehling could we do that? |
@jogendra, I think by Changing the outdated pod to the latest pod is a better and long term solution. |
I will make a PR soon for the new pods. |
@jogendra the pods which I mentioned earlier are now updated to the latest version, now the project is building successfully without any errors. Please check it in your local repository too. |
@baquer The circle-ci test is failing. PR cannot be reviewed/merge till it pass all the test. Please first pass all the test, test it well from your side then ping here. |
Closing the PR due to inactivity. Feel free to open a new PR. |
Fixes #539
Changes: Conversion to swift 5
Screenshots for the change:
N/A