Skip to content

ci(doc): document feature sync #12498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2025
Merged

ci(doc): document feature sync #12498

merged 1 commit into from
Nov 8, 2025

Conversation

@rplusq
Copy link
Contributor

@rplusq rplusq commented Nov 8, 2025 •
edited
Loading

Summary

  • Add turnkey to the RUST_FEATURES env shared by release.yml and docker-publish.yml so nightly/stable tarballs and Docker images ship binaries with the new signer enabled.
  • Document in docs/dev/README.md that the workflow env var must stay in sync with the Makefile’s default feature list to avoid future drift.

Testing

cargo build --profile maxperf --no-default-features --features "aws-kms,gcp-kms,turnkey,cli,asm-
keccak,js-tracer"

target/maxperf/cast send --help | grep -n turnkey

239:      --turnkey
245:          See: <https://docs.turnkey.com/getting-started/quickstart>

@rplusq rplusq changed the title ci/turnkey release binary ci(doc): document feature sync Nov 8, 2025
@rplusq rplusq force-pushed the ci/turnkey-release-binary branch from d05de2d to 1847ccd Compare November 8, 2025 06:15
mattsse
mattsse approved these changes Nov 8, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah

docs/dev/README.md

If `make test` passes locally, that's a good sign that CI will be green as well.

## Release Features
Copy link
Member

@mattsse mattsse Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helpful, ty

@mattsse mattsse enabled auto-merge November 8, 2025 06:16
@mattsse mattsse added A-ci Area: CI A-docs Area: docs labels Nov 8, 2025
@mattsse mattsse added this pull request to the merge queue Nov 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2025
@rplusq
Copy link
Contributor Author

rplusq commented Nov 8, 2025

@mattsse flaky test failed

@mattsse mattsse added this pull request to the merge queue Nov 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 8, 2025
@mattsse mattsse added this pull request to the merge queue Nov 8, 2025
Merged via the queue into foundry-rs:master with commit cca5d6f Nov 8, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Nov 8, 2025
@rplusq rplusq deleted the ci/turnkey-release-binary branch November 8, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

No one assigned

Labels

A-ci Area: CI A-docs Area: docs

Projects

Foundry
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rplusq @mattsse