From 05f65d90e40de25723bf428ac0e5e87372d9025d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 3 Jun 2026 06:57:11 +0000 Subject: [PATCH 1/3] chore(deps-dev): bump spring from 4.5.0 to 4.6.0 Bumps [spring](https://github.com/rails/spring) from 4.5.0 to 4.6.0. - [Release notes](https://github.com/rails/spring/releases) - [Changelog](https://github.com/rails/spring/blob/main/CHANGELOG.md) - [Commits](https://github.com/rails/spring/compare/v4.5.0...v4.6.0) --- updated-dependencies: - dependency-name: spring dependency-version: 4.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index e2fa012..281cfce 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -490,7 +490,7 @@ GEM fugit (~> 1.11) railties (>= 7.1) thor (>= 1.3.1) - spring (4.5.0) + spring (4.6.0) spring-commands-rspec (1.0.4) spring (>= 0.9.1) stimulus-rails (1.3.4) From a227bc43651fb08ca320a1af508ce112b9fdf212 Mon Sep 17 00:00:00 2001 From: fralps Date: Wed, 3 Jun 2026 14:57:17 +0200 Subject: [PATCH 2/3] chore: comment out licenses job in CI workflow for future re-enablement --- .github/workflows/ci.yml | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9e4b136..d1bc5f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -79,23 +79,24 @@ jobs: STAGING_ENV: 'false' run: bundle exec rspec --profile -f j -o tmp/rspec_results.json -f p - licenses: - name: ©️ Licenses - if: success() - needs: testing - runs-on: ubuntu-latest - steps: - - name: 🔧 Checkout code - uses: actions/checkout@v6 - - - uses: oven-sh/setup-bun@v2 - with: - bun-version: latest - - - name: 🧪 Run licenses check - uses: fralps/github-actions/check-licenses@main - with: - package-manager: bun + # TODO: fix this job and enable it again + # licenses: + # name: ©️ Licenses + # if: success() + # needs: testing + # runs-on: ubuntu-latest + # steps: + # - name: 🔧 Checkout code + # uses: actions/checkout@v6 + + # - uses: oven-sh/setup-bun@v2 + # with: + # bun-version: latest + + # - name: 🧪 Run licenses check + # uses: fralps/github-actions/check-licenses@main + # with: + # package-manager: bun security: name: 🔒 Security From b5cc0bfa9468d1fea9b30f98c303dd65bf75e999 Mon Sep 17 00:00:00 2001 From: fralps Date: Wed, 3 Jun 2026 15:50:09 +0200 Subject: [PATCH 3/3] chore: update params access to use expect method in controllers --- app/controllers/api/v1/admin/users_controller.rb | 2 +- app/controllers/api/v1/sleeps_controller.rb | 4 +++- app/controllers/concerns/search_concern.rb | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/app/controllers/api/v1/admin/users_controller.rb b/app/controllers/api/v1/admin/users_controller.rb index 4ed0753..20421c5 100644 --- a/app/controllers/api/v1/admin/users_controller.rb +++ b/app/controllers/api/v1/admin/users_controller.rb @@ -39,7 +39,7 @@ def double_admin_check end def find_user - @user = User.includes(user_includes).find(params[:id]) + @user = User.includes(user_includes).find(params.expect(:id)) end def user_includes diff --git a/app/controllers/api/v1/sleeps_controller.rb b/app/controllers/api/v1/sleeps_controller.rb index 35c72c3..1ff0061 100644 --- a/app/controllers/api/v1/sleeps_controller.rb +++ b/app/controllers/api/v1/sleeps_controller.rb @@ -78,7 +78,7 @@ def analyse private def find_sleep - @sleep = current_user.sleeps.find(params[:id]) + @sleep = current_user.sleeps.find(params.expect(:id)) end def format_date_params @@ -86,7 +86,9 @@ def format_date_params timestamp = Time.zone.local(date_hash['year'], date_hash['month'], date_hash['day']) + # rubocop:disable Rails/StrongParametersExpect params[:sleep][:date] = timestamp + # rubocop:enable Rails/StrongParametersExpect end def sleep_params diff --git a/app/controllers/concerns/search_concern.rb b/app/controllers/concerns/search_concern.rb index 8d5186b..cb78e85 100644 --- a/app/controllers/concerns/search_concern.rb +++ b/app/controllers/concerns/search_concern.rb @@ -9,7 +9,7 @@ module SearchConcern def search_query return if params[:query].blank? - params[:query].downcase + params.expect(:query).downcase end # Return search results with a title query