Skip to content

Add a bottom margin to ControlLabel #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huyenltnguyen opened this issue May 30, 2024 · 1 comment
Closed

Add a bottom margin to ControlLabel #161

huyenltnguyen opened this issue May 30, 2024 · 1 comment
Assignees
@huyenltnguyen
Labels
release: major Changes that would go in a major release.

Comments

@huyenltnguyen
Copy link
Member

Description

I found that ControlLabel (renders a label) doesn't have a bottom margin, and it sits right above the input when combined with FormControl:

<FormGroup>
  <ControlLabel>Name</ControlLabel>
  <FormControl type="text" />
</FormGroup>

We are currently getting a bottom margin in /learn thanks to Bootstrap: https://github.com/twbs/bootstrap/blob/f17f882df292b29323f1e1da515bd16f326cee4a/dist/css/bootstrap.css#L2609.

I think either ControlLabel should have a bottom margin of 5px, or the FormGroup component should add a space of 5px between its children.
@huyenltnguyen huyenltnguyen added the release: major Changes that would go in a major release. label May 30, 2024
@huyenltnguyen huyenltnguyen self-assigned this May 30, 2024
@huyenltnguyen huyenltnguyen changed the title Add a bottom margin to the label element of ControlLabel Add a bottom margin to ControlLabel May 30, 2024
@huyenltnguyen
Copy link
Member Author

Closing as this issue will be addressed via https://github.com/freeCodeCamp/ui/pull/466/files#diff-5e64d0cc9c46937489d71595a4efb9d03f22574a0e83ca8b132a8833e03e6c60R55.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huyenltnguyen huyenltnguyen

Labels
release: major Changes that would go in a major release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huyenltnguyen