Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Col] Add 4 as an option of the xs prop #162

Closed
huyenltnguyen opened this issue May 30, 2024 · 0 comments · Fixed by #520
Closed

[Col] Add 4 as an option of the xs prop #162

huyenltnguyen opened this issue May 30, 2024 · 0 comments · Fixed by #520
Labels
help wanted Open for all. You do not need permission to work on these. release: minor Changes that would go in a minor release.

Comments

@huyenltnguyen
Copy link
Member

huyenltnguyen commented May 30, 2024

Description

In /learn, we have a layout where xs={4} is required:

https://github.com/freeCodeCamp/freeCodeCamp/blob/b234cf80970e2b01a8175e4d9ce3a40ba0c85cbf/client/src/components/settings/certification.tsx#L391

But the Col component doesn't support 4 as an xs value:

xs?: 6 | 8 | 10 | 12;

Changes needed:

@huyenltnguyen huyenltnguyen self-assigned this May 30, 2024
@huyenltnguyen huyenltnguyen changed the title Add 4 as an option of the xs prop in Col [Col] Add 4 as an option of the xs prop Mar 14, 2025
@huyenltnguyen huyenltnguyen removed their assignment Mar 14, 2025
@huyenltnguyen huyenltnguyen added help wanted Open for all. You do not need permission to work on these. release: minor Changes that would go in a minor release. labels Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open for all. You do not need permission to work on these. release: minor Changes that would go in a minor release.
Projects
None yet
1 participant