Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port CSS overrides from /learn to base.css #167

Closed
Tracked by #522
huyenltnguyen opened this issue Jun 4, 2024 · 1 comment · Fixed by #466
Closed
Tracked by #522

Port CSS overrides from /learn to base.css #167

huyenltnguyen opened this issue Jun 4, 2024 · 1 comment · Fixed by #466
Assignees
Labels
release: major Changes that would go in a major release.

Comments

@huyenltnguyen
Copy link
Member

huyenltnguyen commented Jun 4, 2024

Description

Tailwind preflight removes some default browser styles while we are still using them (via Bootstrap).

I had to make some Tailwind overrides in freeCodeCamp/freeCodeCamp#55068, and those overrides should be moved to the base.css stylesheet of the UI library to ensure the default styles are consistent across downstream apps.

Note

This will be a breaking change as the added styles could affect the UI of the consumers.

@huyenltnguyen huyenltnguyen self-assigned this Jun 4, 2024
@huyenltnguyen huyenltnguyen added the release: major Changes that would go in a major release. label Mar 19, 2025
@huyenltnguyen huyenltnguyen mentioned this issue Mar 19, 2025
3 tasks
@huyenltnguyen
Copy link
Member Author

I've gone through the /learn styles, and I think the following styles should be excluded from the library's default:

  • legend
    • color: #333 (code): The color isn't in our design system
    • border-bottom: 1px solid #e5e5e5 (code): The color isn't in our design system, and we don't use the border anywhere (in /learn anywhere legend is used, we have to override the border and set it to none)
  • blockquote
    • border-left: 5px solid #eeeeee (code): The color should be changed to a color in our design system, it probably should be background-quaternary
  • blockquote footer, blockquote small, blockquote .small (code): Should be removed from the global.css file. The :before styles can be moved to client/src/components/Intro/index.tsx, which is the only place needs it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: major Changes that would go in a major release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant