include/servtree.h: fix null pointer dereference

Janik Kleinhoff · Janik Kleinhoff · commit 68207fa7bb63 · 2014-08-17T08:01:21.000+02:00
svs can be NULL when we are logging /stats &lt;letter&gt; services. so check
for that case before looking up -&gt;logtarget.
diff --git a/include/servtree.h b/include/servtree.h
@@ -38,7 +38,7 @@ struct service_ {
 
 static inline const char *service_get_log_target(const service_t *svs)
 {
-	if (svs->logtarget != NULL)
+	if (svs != NULL && svs->logtarget != NULL)
 		return service_get_log_target(svs->logtarget);
 
 	return svs != NULL ? svs->nick : me.name;

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ struct service_ {`
`38`	`38`
`39`	`39`	`static inline const char service_get_log_target(const service_t svs)`
`40`	`40`	`{`
`41`		`- if (svs->logtarget != NULL)`
	`41`	`+ if (svs != NULL && svs->logtarget != NULL)`
`42`	`42`	`return service_get_log_target(svs->logtarget);`
`43`	`43`
`44`	`44`	`return svs != NULL ? svs->nick : me.name;`