Remove NetworkImage, add Nuke to display images

Author: frenme

Package.resolved

@@ -17,25 +17,17 @@ let package = Package(
     )
   ],
   dependencies: [
-    .package(url: "https://github.com/gonzalezreal/NetworkImage", from: "6.0.0"),
-    .package(url: "https://github.com/pointfreeco/swift-snapshot-testing", from: "1.10.0"),
+    .package(url: "https://github.com/kean/Nuke", from: "12.0.0")
   ],
   targets: [
     .target(name: "cmark-gfm"),
     .target(
       name: "MarkdownUI",
       dependencies: [
         "cmark-gfm",
-        .product(name: "NetworkImage", package: "NetworkImage"),
+        .product(name: "Nuke", package: "Nuke"),
+        .product(name: "NukeUI", package: "Nuke"),
       ]
-    ),
-    .testTarget(
-      name: "MarkdownUITests",
-      dependencies: [
-        "MarkdownUI",
-        .product(name: "SnapshotTesting", package: "swift-snapshot-testing"),
-      ],
-      exclude: ["__Snapshots__"]
-    ),
+    )
   ]
 )

Package.swift

@@ -1,23 +1,24 @@
-import NetworkImage
+import NukeUI
 import SwiftUI
 
 /// The default image provider, which loads images from the network.
 public struct DefaultImageProvider: ImageProvider {
-  public func makeImage(url: URL?) -> some View {
-    NetworkImage(url: url) { state in
-      switch state {
-      case .empty, .failure:
-        Color.clear
-          .frame(width: 0, height: 0)
-      case .success(let image, let idealSize):
-        ResizeToFit(idealSize: idealSize) {
-          image.resizable()
+    @MainActor public func makeImage(url: URL?) -> some View {
+        LazyImage(url: url) { state in
+            if let image = state.image {
+                image
+                    .resizable()
+                    .aspectRatio(contentMode: .fit)
+            } else {
+                Color
+                    .clear
+                    .frame(width: 0, height: 0)
+            }
         }
-      }
     }
-  }
 }
 
+
 extension ImageProvider where Self == DefaultImageProvider {
   /// The default image provider, which loads images from the network.
   ///

Sources/MarkdownUI/Extensibility/DefaultImageProvider.swift

@@ -1,15 +1,12 @@
-import NetworkImage
+import Nuke
 import SwiftUI
 
 /// The default inline image provider, which loads images from the network.
 public struct DefaultInlineImageProvider: InlineImageProvider {
-  public func image(with url: URL, label: String) async throws -> Image {
-    try await Image(
-      DefaultNetworkImageLoader.shared.image(from: url),
-      scale: 1,
-      label: Text(label)
-    )
-  }
+    @MainActor public func image(with url: URL, label: String) async throws -> Image {
+        guard let cgImage = try await ImagePipeline.shared.image(for: url).cgImage else { return .init(uiImage: .init()) }
+        return Image(cgImage, scale: 1, label: Text(label))
+    }
 }
 
 extension InlineImageProvider where Self == DefaultInlineImageProvider {