Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display keybindings in help menu in sorted way #98

Open
fritzrehde opened this issue Feb 2, 2024 · 0 comments
Open

Display keybindings in help menu in sorted way #98

fritzrehde opened this issue Feb 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@fritzrehde
Copy link
Owner

There are different possibilities of how to sort the keybindings when displaying, but this is my preferred one:
Sort according to their configuration hierarchy and insertion order: Larger (in terms of config hierarchy, e.g. cli > global toml file) keybindings should be closer to the top, and inside a common config hierarchy the order should be exactly the way it was specified by the user (in the toml file or via cli). This would be the most user-friendly implementation, it allows the user to see the keybindings just the way they ordered them. We could use indexmap to get a hashmap that retains insertion order.

@fritzrehde fritzrehde added the enhancement New feature or request label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant