rootKey in getTreeFromFlatData not behaving correctly for string based keys

[adeperio]

Hi, think I've found a bug,

When trying to use the getTreeFromFlat data function, and:

1. Your id's are global strings
2. Your tree doesn't have a rootKey

The function keeps returning back an empty array []

I think this is a bug in the function in the following code block
https://github.com/fritz-c/react-sortable-tree/blob/337a633e75a761f6a10bdf9ea0e2d06d82e603b9/src/utils/tree-data-utils.js#L993

I think this shouldn't return an empty array if no rootKey is give.

I've also tried setting it to '0' as per #189 but that's not helping either.

Any ideas what else it could be?

Thanks

[adeperio]

Also, I noticed this function is using recursion to build the tree.

Just wanted to reference this StackOverflow question here:
https://stackoverflow.com/questions/18017869/build-tree-array-from-flat-array-in-javascript

Is recursion the most efficient method to build the tree from a flat data structure?

[wuweiweiwu]

Hi @adeperio do you mind posting a repro? a JS snippet or even codesandbox would be appreciated :)

[adeperio]

@wuweiweiwu sorry haven't had time to look into this yet, on my radar though :) I actually ended up going with a solution that doesn't use recursion (based from that SO link above) which I think might be a better performer?

[wuweiweiwu]

I see, thanks! I'll be taking a deep dive in to react-sortable-tree soon so I'll keep that in mind.