Skip to content

Commit 44f7b16

Browse files
authored
Fix reference to MMapCache in CachingFileSystem docstring (#935)
* Fix reference to MMapCache in CachingFileSystem docstring * Fix line length of cached.py * Fix unnecessary highlight reference * Add numpydoc_show_class_members=False to sphinx conf.py * Fix docstring formatting for ReferenceFileSystem * Add smbclient to sphinx docs mocked packages * Fix underline length issue in docstring * Fix incorrect HadoopFileSystem autodoc reference
1 parent 21a03a0 commit 44f7b16

File tree

6 files changed

+9
-4
lines changed

6 files changed

+9
-4
lines changed

docs/source/api.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ Built-in Implementations
138138
.. autoclass:: fsspec.implementations.arrow.ArrowFSWrapper
139139
:members: __init__
140140

141-
.. autoclass:: fsspec.implementations.hdfs.HadoopFileSystem
141+
.. autoclass:: fsspec.implementations.arrow.HadoopFileSystem
142142
:members: __init__
143143

144144
.. autoclass:: fsspec.implementations.dask.DaskWorkerFileSystem

docs/source/conf.py

+3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
"numpydoc",
4040
]
4141

42+
numpydoc_show_class_members = False
43+
4244
# Add any paths that contain templates here, relative to this directory.
4345
templates_path = ["_templates"]
4446

@@ -99,6 +101,7 @@
99101
"pygit2",
100102
"requests",
101103
"smbprotocol",
104+
"smbclient",
102105
]
103106

104107

docs/source/intro.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Other similar work
6969
------------------
7070

7171
It might have been conceivable to reuse code in ``pyfilesystems``, which has an established interface and several
72-
implementations of its own. However, it supports none of the :ref:`highlight`, critical to
72+
implementations of its own. However, it supports none of the **critical** features for
7373
cloud and parallel access, and would not be easy to
7474
coerce. Following on the success of ``s3fs`` and ``gcsfs``, and their use within Dask, it seemed best to
7575
have an interface as close to those as possible. See a

fsspec/caching.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def cache_info(self):
229229
The statistics on the block cache.
230230
231231
Returns
232-
----------
232+
-------
233233
NamedTuple
234234
Returned directly from the LRU Cache used internally.
235235
"""

fsspec/implementations/cached.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ class CachingFileSystem(AbstractFileSystem):
2626
directory with random hashes for the filenames. If no directory is given,
2727
a temporary one is used, which should be cleaned up by the OS after the
2828
process ends. The files themselves are sparse (as implemented in
29-
:class:`~fsspec.core.MMapCache`), so only the data which is accessed takes up space.
29+
:class:`~fsspec.caching.MMapCache`), so only the data which is accessed
30+
takes up space.
3031
3132
Restrictions:
3233

fsspec/implementations/reference.py

+1
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def __init__(
109109
- a dict of protocol:filesystem, where each value is either a filesystem
110110
instance, or a dict of kwargs that can be used to create in
111111
instance for the given protocol
112+
112113
If this is given, remote_options and remote_protocol are ignored.
113114
template_overrides : dict
114115
Swap out any templates in the references file with these - useful for

0 commit comments

Comments
 (0)