Skip to content

Commit 1fdf4a4

Browse files
authored
Merge pull request #372 from fugerit-org/317-chore-migrate-junit4-to-junit5
[fj-doc-mod-openpdf-ext] migrate junit4 to junit5 #370
2 parents 43537eb + e252e48 commit 1fdf4a4

File tree

3 files changed

+24
-24
lines changed

3 files changed

+24
-24
lines changed

fj-doc-mod-poi/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,8 @@
8787
</dependency>
8888

8989
<dependency>
90-
<groupId>junit</groupId>
91-
<artifactId>junit</artifactId>
90+
<groupId>org.junit.jupiter</groupId>
91+
<artifactId>junit-jupiter-api</artifactId>
9292
<scope>test</scope>
9393
</dependency>
9494

fj-doc-mod-poi/src/test/java/test/org/fugerit/java/doc/mod/poi/coverage/TestPOIUtils.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@
1212
import org.fugerit.java.doc.base.model.DocCell;
1313
import org.fugerit.java.doc.mod.poi.PoiUtils;
1414
import org.fugerit.java.doc.mod.poi.WorkbookHelper;
15-
import org.junit.Assert;
16-
import org.junit.Test;
1715

1816
import lombok.extern.slf4j.Slf4j;
17+
import org.junit.jupiter.api.Assertions;
18+
import org.junit.jupiter.api.Test;
1919

2020
@Slf4j
21-
public class TestPOIUtils {
21+
class TestPOIUtils {
2222

2323

2424
@Test
25-
public void xlsxFormatStyle() {
26-
Assert.assertTrue( SafeFunction.get( () -> {
25+
void xlsxFormatStyle() {
26+
Assertions.assertTrue( SafeFunction.get( () -> {
2727
boolean ok = Boolean.TRUE;
2828
PoiUtils.xlsxFormatStyle(null, null, null);
2929
PoiUtils.xlsxFormatStyle(null, new XSSFCellStyle( null), null );
@@ -32,17 +32,17 @@ public void xlsxFormatStyle() {
3232
}
3333

3434
@Test
35-
public void xlsxFontStyle() {
36-
Assert.assertTrue( SafeFunction.get( () -> {
35+
void xlsxFontStyle() {
36+
Assertions.assertTrue( SafeFunction.get( () -> {
3737
boolean ok = Boolean.TRUE;
3838
PoiUtils.xlsxFontStyle(null, null, null);
3939
return ok;
4040
} ) );
4141
}
4242

4343
@Test
44-
public void lsxFormat() {
45-
Assert.assertTrue( SafeFunction.get( () -> {
44+
void lsxFormat() {
45+
Assertions.assertTrue( SafeFunction.get( () -> {
4646
boolean ok = Boolean.TRUE;
4747
try ( InputStream is = ClassHelper.loadFromDefaultClassLoader( "coverage/xls_as_xls.xls" );
4848
HSSFWorkbook workbook = new HSSFWorkbook( is ) ) {
@@ -56,9 +56,9 @@ public void lsxFormat() {
5656
}
5757

5858
@Test
59-
public void testFindColor() {
59+
void testFindColor() {
6060
Short test = 31;
61-
Assert.assertEquals( test, SafeFunction.get( () -> {
61+
Assertions.assertEquals( test, SafeFunction.get( () -> {
6262
try ( InputStream is = ClassHelper.loadFromDefaultClassLoader( "coverage/xls_as_xls.xls" );
6363
HSSFWorkbook workbook = new HSSFWorkbook( is ) ) {
6464
short index = PoiUtils.findClosestColorIndex( workbook , "#dddddd" );
@@ -69,15 +69,15 @@ public void testFindColor() {
6969
}
7070

7171
@Test
72-
public void testNewHelper() {
72+
void testNewHelper() {
7373
SafeFunction.apply( () -> {
7474
try ( InputStream is = ClassHelper.loadFromDefaultClassLoader( "coverage/xls_as_xls.xls" );
7575
WorkbookHelper helper = PoiUtils.newHelper( false , is ) ) {
7676
log.info( "test 1 -> {}", helper.getIndexedColorMap() );
77-
Assert.assertNotNull( helper );
77+
Assertions.assertNotNull( helper );
7878
}
7979
} );
80-
Assert.assertNotNull( SafeFunction.get( () -> {
80+
Assertions.assertNotNull( SafeFunction.get( () -> {
8181
try ( InputStream is = ClassHelper.loadFromDefaultClassLoader( "coverage/xlsx_as_xlsx.xlsx" );
8282
WorkbookHelper helper = PoiUtils.newHelper( true , is ) ) {
8383
log.info( "test 2 -> {}", helper.getIndexedColorMap() );
@@ -89,10 +89,10 @@ public void testNewHelper() {
8989
private static final IOException FAIL_EX = new IOException( "scenario exception" );
9090

9191
@Test
92-
public void testAutoresizeFailhandler() {
92+
void testAutoresizeFailhandler() {
9393
PoiUtils.autoresizeFailHandler( false ).accept( FAIL_EX );
9494
Consumer<Exception> exHandlerFail = PoiUtils.autoresizeFailHandler( true );
95-
Assert.assertThrows( ConfigRuntimeException.class , () -> exHandlerFail.accept( FAIL_EX ) );
95+
Assertions.assertThrows( ConfigRuntimeException.class , () -> exHandlerFail.accept( FAIL_EX ) );
9696
}
9797

9898
}

fj-doc-mod-poi/src/test/java/test/org/fugerit/java/doc/mod/poi/coverage/TestPoiCoverage.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
import org.fugerit.java.doc.base.config.DocTypeHandler;
1313
import org.fugerit.java.doc.mod.poi.XlsPoiTypeHandler;
1414
import org.fugerit.java.doc.mod.poi.XlsxPoiTypeHandler;
15-
import org.junit.Assert;
16-
import org.junit.Test;
15+
import org.junit.jupiter.api.Assertions;
16+
import org.junit.jupiter.api.Test;
1717

18-
public class TestPoiCoverage {
18+
class TestPoiCoverage {
1919

2020
private final static String[] TEST_LIST = { "default_doc", "default_doc_alt", "default_doc_fail1" };
2121

@@ -37,11 +37,11 @@ private boolean worker( String path ) {
3737
}
3838

3939
@Test
40-
public void test01() {
40+
void test01() {
4141
Arrays.asList( TEST_LIST ).stream().forEach( c -> {
42-
Assert.assertTrue( this.worker( "coverage/xml/"+c+".xml" ) );
42+
Assertions.assertTrue( this.worker( "coverage/xml/"+c+".xml" ) );
4343
} );
44-
Assert.assertTrue( Boolean.TRUE );
44+
Assertions.assertTrue( Boolean.TRUE );
4545
}
4646

4747
}

0 commit comments

Comments
 (0)