It'd be helpful if OffTargetDetector did not require Oligo or PrimerPair objects as input.
The off-target detection does not use any of the primer-related metrics that appear on these classes (e.g. tm, penalty), and this design constraint makes it challenging to reuse this functionality in other contexts.
I think the detection methods could be re-written to accept strings (or string tuples, for pair checking) as input. We could also consider accepting a Protocol for any class that includes a sequence or bases attribute.
It'd be helpful if
OffTargetDetectordid not requireOligoorPrimerPairobjects as input.The off-target detection does not use any of the primer-related metrics that appear on these classes (e.g.
tm,penalty), and this design constraint makes it challenging to reuse this functionality in other contexts.I think the detection methods could be re-written to accept strings (or string tuples, for pair checking) as input. We could also consider accepting a
Protocolfor any class that includes asequenceorbasesattribute.