-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Enable no lags in Forecaster class #214
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added Value error to prevent running the backtest without features
Ciao @jhug12 and sorry for missing out - I was swamped with work. I will review this hopefully this week. In the meantime: thank you very much for your work. I am merging a couple of other things, so I will ping you later to rebase this branch against main. |
Hi @baggiponte! No worries at all, I totally understand being busy with work. Thanks so much for handling the merging, and just give me a heads-up whenever you need me to rebase the branch. I appreciate your efforts! |
Reference Issues/PRs
Fixes #205
Summary
This pull request introduces the initial implementation of the
lags=None
feature, which currently only functions with thestrategy="recursive"
setting. If this approach meets the requirements for solving the referenced issue, I recommend expanding this functionality in a uniform manner throughout the codebase.Proposed Changes
lags=None
option in the context ofstrategy="recursive"
.Code to Test the Implementation