Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform forecaster strategy parameter validation on init #217

Open
baggiponte opened this issue Jun 4, 2024 · 1 comment
Open

Perform forecaster strategy parameter validation on init #217

baggiponte opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request forecasting Forecasters and adapters good first issue Good for newcomers
Milestone

Comments

@baggiponte
Copy link
Collaborator

Was chatting with @FBruzzesi about functime and realised this does not raise.

from functime.forecasting import linear_model

model = linear_model(freq="1mo", lags=4, strategy="ashdfaskldj")

model.name

Validation happens in .fit(). I guess we should move this validation on forecaster definition.

@baggiponte baggiponte self-assigned this Jun 4, 2024
@baggiponte baggiponte added enhancement New feature or request good first issue Good for newcomers forecasting Forecasters and adapters labels Jun 4, 2024
@srihitha2005
Copy link

Hi ,
I'm interested in contributing to this repository. I came across this issue and was wondering if I could help resolve it.
Before I start working on it, I wanted to check if the issue is still open and if anyone else is currently working on it. Could you please let me know the status of this issue?

@baggiponte baggiponte added this to the 0.9.X milestone Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request forecasting Forecasters and adapters good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants