Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(223): Replace deprecated _get_shared_lib_location with register_plugin_function #245

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khrapovs
Copy link
Contributor

Reference Issues/PRs

Fixes #223

What does this implement/fix? Explain your changes.

Replace deprecated _get_shared_lib_location with register_plugin_function.

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 8:17am

@jonimatix
Copy link

This errors comes from the latest update of Polars.

Returns:
ModuleNotFoundError: No module named 'polars.utils'

Stack:
import polars as pl [7](file:///C:/Users/ia/.conda/envs/env/Lib/site-packages/functime/feature_extractors.py:7) from polars.type_aliases import ClosedInterval ----> [8](file:///C:/Users/ia/.conda/envs/env/Lib/site-packages/functime/feature_extractors.py:8) from polars.utils.udfs import _get_shared_lib_location [10](file:///C:/Users/ia/.conda/envs/env/Lib/site-packages/functime/feature_extractors.py:10) # from numpy.linalg import lstsq [11](file:///C:/Users/ia/.conda/envs/env/Lib/site-packages/functime/feature_extractors.py:11) from scipy.linalg import lstsq

@jonimatix
Copy link

Hi,

Is there an update on when the final merge to master going to happen?

Thank you

@rvandewater
Copy link

@baggiponte This is one of the main things that makes functime polars >1,0 compatible it seems. Would be useful to at least provide a dev version that implements this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: _get_shared_lib_location is deprecated
3 participants