Updates for 0.0.3 release

Signed-off-by: Matthew Ballance <[email protected]>

Author: mballance

doc/ChangeLog.md

@@ -1,4 +1,10 @@
 
+## 0.0.3
+- (#29) - Resolve issues with tasks and Python GIL
+- (#22) - Resolve return value issue
+- () - Add support for AMD Xilinx Xsim simulator
+- () - Move tests over to use the DV Flow Manager PyTest extension
+
 ## 0.0.2
 - (#25) - Correct issue passing string-type parameters
 

setup.py

@@ -6,7 +6,7 @@
 import sysconfig
 from setuptools import Extension, setup, find_namespace_packages
 
-version="0.0.2"
+version="0.0.3"
 
 proj_dir = os.path.dirname(os.path.abspath(__file__))
 pythondir = os.path.join(proj_dir, "src")

src/hdl_if/impl/call/call_proxy_dpi.py

@@ -46,7 +46,6 @@ async def invoke_hdl_t(
         from hdl_if.backend import Backend
         be = Backend.inst();
         evt = be.mkEvent()
-#        param = (method_name,)
         param = method_name
 
         self.ep.invoke_hdl_t(self.obj_id, evt, param, args)

src/hdl_if/impl/call/gen_sv_class.py

@@ -386,9 +386,10 @@ def gen_tf_impl(self, m : MethodDef):
     def gen_task_dispatch(self, api):
         self.println("virtual task invokeTask(")
         self.inc_ind()
-        self.println("output pyhdl_if::PyObject retval,")
-        self.println("input string method,")
-        self.println("input pyhdl_if::PyObject args);")
+        self.println("output pyhdl_if::PyObject        retval,")
+        self.println("inout pyhdl_if::PyGILState_STATE state,")
+        self.println("input string                     method,")
+        self.println("input pyhdl_if::PyObject         args);")
         self.dec_ind()
         self.println()
         self.inc_ind()
@@ -410,6 +411,7 @@ def gen_task_dispatch(self, api):
                         self.py2sv_func(p[1]),
                         i
                     ))
+                self.println("pyhdl_if::PyGILState_Release(state); // Release the GIL before invoking the task")
                 self.write("%s" % self._ind)
                 self.write("%s" % m.name)
                 if len(m.params) == 0:
@@ -429,6 +431,9 @@ def gen_task_dispatch(self, api):
                             "," if (i+1 < len(m.params)) else ");"
                         ))
                     self.dec_ind()
+
+                self.println("state = pyhdl_if::PyGILState_Ensure(); // Reacquire the GIL after invoking the task")
+
                 if m.rtype is not None:
                     self.println("retval = %s;" % self.sv2py_func(m.rtype, "__retval"))
                 self.dec_ind()

src/hdl_if/share/dpi/pyhdl_if_icall_api.svh

@@ -25,8 +25,9 @@ interface class ICallApi;
         PyObject            args);
 
     pure virtual task invokeTask(
-        output PyObject     retval,
-        input string        method,
-        input PyObject      args);
+        output PyObject         retval,
+        inout PyGILState_STATE  state,
+        input string            method,
+        input PyObject          args);
 
 endclass

src/hdl_if/share/dpi/pyhdl_if_taskcall_closure.svh

@@ -27,7 +27,7 @@ class TaskCallClosure implements PyHdlPiRunnable;
         evt_obj_set = PyObject_GetAttrString(m_evt_obj, "set");
         args = PyTuple_New(1);
 
-        m_obj.invokeTask(res, m_method_name, m_args);
+        m_obj.invokeTask(res, state, m_method_name, m_args);
 
         if (res == null) begin
             res = None;