fix: show notifications over fullscreen apps - #604
Open
Cyrene2008 wants to merge 1 commit into
Open
Conversation
…cationState guard The SHQueryUserNotificationState API returns QUNS_RUNNING_D3D_FULL_SCREEN when any fullscreen app is active, causing the notification to be silently discarded. The FxNotification component already has setAlwaysOnTop(true) and addToDesktop(0) with toFront(true), which is sufficient for borderless fullscreen apps. The guard was unnecessarily suppressing notifications for a non-intrusive, auto-hiding overlay that does not steal focus.
Member
|
With this change FxSound notification will be shown even in full screen mode and presentation mode which is not the correct application behaviour. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FxSound notifications don't show over many/majority of windows in fullscreen (mpv, VLC, Firefox, Brave on Windows 11). When using Next/Previous Preset keyboard shortcuts while in fullscreen, you cannot see which preset you're on.
Root Cause
FxSystemTrayView::showNotification() calls SHQueryUserNotificationState() which returns QUNS_RUNNING_D3D_FULL_SCREEN when any fullscreen app is active. The notification is silently discarded with an early
eturn — no fallback, no user feedback.
Fix
Remove the SHQueryUserNotificationState guard. The notification component (FxNotification) already has setAlwaysOnTop(true) and �ddToDesktop(0) with oFront(true), which is sufficient for borderless fullscreen apps. The notification is a small, non-intrusive overlay that auto-hides in 7-8 seconds and does not steal focus — there is no good reason to suppress it during fullscreen.
Testing
Fixes #596