Skip to content

Commit 47e2a13

Browse files
Clarify header ordering indicators
1 parent d68064e commit 47e2a13

File tree

3 files changed

+33
-5
lines changed

3 files changed

+33
-5
lines changed

msgfmt:ui/lib/client.js

+9
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,15 @@ Template.mfTransLang.helpers({
264264
caseInsensitiveOrdering: function() {
265265
return Session.get('caseInsensitiveOrdering');
266266
},
267+
sortOrderHeaderClass: function(headerSortField) {
268+
var classes = '';
269+
var sortField = Session.get('translationSortField');
270+
var sortOrder = Session.get('translationSortOrder');
271+
if (headerSortField === sortField) {
272+
classes += ' active-sort ' + sortOrder;
273+
}
274+
return classes
275+
},
267276
stateClass: function() {
268277
if (this.fuzzy)
269278
return 'fuzzy';

msgfmt:ui/lib/ui.css

+12
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,18 @@ div.mfTransGraph.untrans { background: #800; border-right: 1px solid black; }
7777

7878
#mfTransLang .options label { margin-right: 10px; }
7979

80+
#mfTransLang th { position: relative; }
81+
#mfTransLang th.active-sort { background-color: #CCC; }
82+
#mfTransLang th.active-sort a { font-weight: 500; }
83+
#mfTransLang th.active-sort::after {
84+
font-size: 0.6em;
85+
position: absolute;
86+
top: 5px;
87+
right: 10px;
88+
}
89+
#mfTransLang th.active-sort.asc::after { content: '▲'; }
90+
#mfTransLang th.active-sort.desc::after { content: '▼'; }
91+
8092
#mfTransLang textarea {
8193
font-family: monospace;
8294
height: 5em; width: 100%;

msgfmt:ui/lib/ui.html

+12-5
Original file line numberDiff line numberDiff line change
@@ -74,10 +74,16 @@ <h2>{{mf 'mf_site_translations' 'Site Translations'}}</h2>
7474
<thead>
7575
<tr>
7676
{{#if showKey}}
77-
<th><a href="#" class="translationSort" data-sortField="key">Key</a></th>
77+
<th class="{{sortOrderHeaderClass 'key'}}">
78+
<a href="#" class='translationSort' data-sortField="key">Key</a>
79+
</th>
7880
{{/if}}
79-
<th><a href="#" class="translationSort" data-sortField="orig">Original String ({{origLang}})</a></th>
80-
<th><a href="#" class="translationSort" data-sortField="trans">Translation ({{destLang}})</a></th>
81+
<th class="{{sortOrderHeaderClass 'orig'}}">
82+
<a href="#" class="translationSort" data-sortField="orig">Original String ({{origLang}})</a>
83+
</th>
84+
<th class="{{sortOrderHeaderClass 'trans'}}">
85+
<a href="#" class="translationSort" data-sortField="trans">Translation ({{destLang}})</a>
86+
</th>
8187
</tr>
8288
</thead>
8389
</table>
@@ -104,9 +110,10 @@ <h2>{{mf 'mf_site_translations' 'Site Translations'}}</h2>
104110
</label>
105111
<label>
106112
<input type='checkbox' id='translationCaseInsensitiveOrdering' {{isCheckboxChecked caseInsensitiveOrdering}}>
107-
Case Insensitive Ordering
113+
Case insensitive ordering
108114
</label>
109-
Use ctrl-up and ctrl-down to quickly change keys
115+
<br />
116+
Use ctrl-up and ctrl-down to quickly change keys & click on headers to reorder the columns.
110117
</p>
111118
<span><b>{{keyInfo.key}}</b> in {{keyInfo.file}}:{{keyInfo.line
112119
}}{{#if keyInfo.template}} (template

0 commit comments

Comments
 (0)