Skip to content

Commit aaee402

Browse files
committed
ui; add note about Session; allow clicking on table header not just link
1 parent 4098379 commit aaee402

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

msgfmt:ui/lib/client.js

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
/*
2+
* NOTE ON USE OF SESSION.SET() ETC
3+
* The messageformat project is around since Meteor 0.5, when this
4+
* was recommended practice. There are better ways to do this now,
5+
* however, with the way things are going, we're going to need to
6+
* rewrite this all with React soon, so it's not a priority.
7+
*/
8+
19
// TODO, if we add a new lang, need to update mfPkg.timestamps
210

311
// Setup in msgfmt:core on server, only used on the client in msgfmt:ui
@@ -265,13 +273,13 @@ Template.mfTransLang.helpers({
265273
return Session.get('caseInsensitiveOrdering');
266274
},
267275
sortOrderHeaderClass: function(headerSortField) {
268-
var classes = '';
276+
var classes = 'translationSort';
269277
var sortField = Session.get('translationSortField');
270278
var sortOrder = Session.get('translationSortOrder');
271279
if (headerSortField === sortField) {
272280
classes += ' active-sort ' + sortOrder;
273281
}
274-
return classes
282+
return classes;
275283
},
276284
stateClass: function() {
277285
if (this.fuzzy)

msgfmt:ui/lib/ui.html

+6-6
Original file line numberDiff line numberDiff line change
@@ -74,15 +74,15 @@ <h2>{{mf 'mf_site_translations' 'Site Translations'}}</h2>
7474
<thead>
7575
<tr>
7676
{{#if showKey}}
77-
<th class="{{sortOrderHeaderClass 'key'}}">
78-
<a href="#" class='translationSort' data-sortField="key">Key</a>
77+
<th class="{{sortOrderHeaderClass 'key'}}" data-sortField="key">
78+
<a href="#">Key</a>
7979
</th>
8080
{{/if}}
81-
<th class="{{sortOrderHeaderClass 'orig'}}">
82-
<a href="#" class="translationSort" data-sortField="orig">Original String ({{origLang}})</a>
81+
<th class="{{sortOrderHeaderClass 'orig'}}" data-sortField="orig">
82+
<a href="#">Original String ({{origLang}})</a>
8383
</th>
84-
<th class="{{sortOrderHeaderClass 'trans'}}">
85-
<a href="#" class="translationSort" data-sortField="trans">Translation ({{destLang}})</a>
84+
<th class="{{sortOrderHeaderClass 'trans'}}" data-sortField="trans">
85+
<a href="#">Translation ({{destLang}})</a>
8686
</th>
8787
</tr>
8888
</thead>

0 commit comments

Comments
 (0)