Skip to content

V2 - Support Flow Router #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isAlmogK opened this issue Aug 17, 2015 · 15 comments
Closed

V2 - Support Flow Router #152

isAlmogK opened this issue Aug 17, 2015 · 15 comments

Comments

@isAlmogK
Copy link

Any plans to support flow router?

@DSpeichert
Copy link
Collaborator

I assume that applies to msgfmt:ui only?

@isAlmogK
Copy link
Author

Yes it would only apply to that, it looks like flow router or something similar might be part of meteor core and everyone is moving towards flow router

@gadicc
Copy link
Owner

gadicc commented Aug 20, 2015

Hey, #133 actually addresses this, but now there is a package https://github.com/nicolaslopezj/meteor-router-layer that provides router agnostic routing support for packages... we will definitely be switching over to use this so that we'll always support all popular Meteor routers without needing to worry about writing the code ourselves.

@gadicc gadicc added this to the v2 milestone Aug 20, 2015
@isAlmogK
Copy link
Author

Sweet

@flipace
Copy link
Contributor

flipace commented Sep 17, 2015

This doesn't work for me yet. This is an issue with router layer though since it doesn't use existing Routers correctly.

@gadicc
Copy link
Owner

gadicc commented Sep 17, 2015

Oh :( Is there an issue open with router-layer about it? Ideally we can fix this once for everyone.

I had tested with flow-router, but just the /translate pages. I didn't see how it interacted with the rest of a site using it.

@tdesc
Copy link

tdesc commented Oct 2, 2015

Hello,
I also moved from iron:router to flow-router since last Meteor version update.
Adding router-layer doesn't help. There is no route for the path: /translate
Is there any kind of workaround?

@flipace
Copy link
Contributor

flipace commented Oct 2, 2015

@tdesc this was/is my temporary workaround: https://www.dropbox.com/s/7uahrtwxuzl62vf/msgfmt-ui-flow-router.zip?dl=0 add this as msgfmt:ui to your packages folder...

@tdesc
Copy link

tdesc commented Oct 2, 2015

I'm in process of recreating my project from scratch for v1.2, since this is only way to fix cordova splashscreen freeze.
@flipace give me some hint where packages folder should be?

@flipace
Copy link
Contributor

flipace commented Oct 2, 2015

@tdesc it would be [project root]/packages/msgfmt:ui - but it's by no means a long-term solution, just a temporary fix

@gadicc should I try to implement my additions and send a PR?

@tdesc
Copy link

tdesc commented Oct 2, 2015

Looks like I'm doing something wrong
I have gadicohen:messageformat, kadira:flow-router and /packages/msgfmt:ui
I use npm-container it created packages folder in root of project, where I copy msgfmt:ui.
Still have an error about undefined route

@tdesc
Copy link

tdesc commented Oct 30, 2015

@gadicc Could you please create empty project with gadicohen:messageformat and kadira:flow-router? I'm still can't make it work.

@gadicc
Copy link
Owner

gadicc commented Oct 30, 2015

hey all, apologies that I haven't been able to spend more time on this recently.

@tdesc, the flow-router support is only in v2. sorry that I didn't notice this from your messages earlier. I've released a new version of v2 now that warns if v0 is still installed.

@flipace, PRs are always welcome :) what did you change? it's working for me.

@DSpeichert
Copy link
Collaborator

I am closing this as it is working (for some at least) in v2.
If there is any more issues with flow-router support through nicolaslopezj/meteor-router-layer, feel free to reopen.

@gadicc
Copy link
Owner

gadicc commented Jan 18, 2016

Yes, if anyone else is still having issues, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants