Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Commit b3b1d4e

Browse files
authored
galasactl can launch tests on old service without a submission id being set. (#348)
Signed-off-by: Mike Cobbett <[email protected]> # Why ? Try running the latest galasactl against a system which doesn't set the submission id, or return it in the response payload to the launch request over REST. It panics with a null pointer exception. Because the submission ID wasn't set. Added an 'if' so that it's more tolerant. This would be the case if someone uses the galasactl tool to launch tests on an older non-0.40.0 system.
1 parent 136d2fb commit b3b1d4e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/runs/submitter.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,9 @@ func (submitter *Submitter) submitRun(
348348
if err == nil {
349349
submittedRun := resultGroup.GetRuns()[0]
350350
nextRun.Group = *submittedRun.Group
351-
nextRun.SubmissionId = *submittedRun.SubmissionId
351+
if submittedRun.SubmissionId != nil {
352+
nextRun.SubmissionId = *submittedRun.SubmissionId
353+
}
352354
nextRun.Name = *submittedRun.Name
353355

354356
submittedRuns[nextRun.Name] = &nextRun

0 commit comments

Comments
 (0)