You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But the card is also used in the workflow editor which has slightly different properties - so I think this type needs to be generalized (unioned with whatever the workflow editor is using). I think those should be stubbed out as needed as interfaces on the client side and the WorkflowCard should be updated to consume either type.
The WorkflowCardList component takes in a Workflow[] array - where workflow is just defined as:
export type Workflow = Record<string, never>;
Again, I think we should stub what is needed on the client and clarify the different types of objects this consumes and have those types setup. This would unblock the vue-tsc work while we wait for backend model objects and it would help prioritize what backend objects are needed and what they should look like for the client.
These things together would cleanup the vue-tsc errors for these components but also properly clarify what the interface for these components really is.
The text was updated successfully, but these errors were encountered:
The comments say:
The
WorkflowCard
component props include:But the card is also used in the workflow editor which has slightly different properties - so I think this type needs to be generalized (unioned with whatever the workflow editor is using). I think those should be stubbed out as needed as interfaces on the client side and the WorkflowCard should be updated to consume either type.
The
WorkflowCardList
component takes in aWorkflow[]
array - where workflow is just defined as:Again, I think we should stub what is needed on the client and clarify the different types of objects this consumes and have those types setup. This would unblock the vue-tsc work while we wait for backend model objects and it would help prioritize what backend objects are needed and what they should look like for the client.
These things together would cleanup the vue-tsc errors for these components but also properly clarify what the interface for these components really is.
The text was updated successfully, but these errors were encountered: