Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typing in WorkflowCard & WorkflowCardList. #19681

Open
jmchilton opened this issue Feb 21, 2025 · 0 comments
Open

Fix Typing in WorkflowCard & WorkflowCardList. #19681

jmchilton opened this issue Feb 21, 2025 · 0 comments

Comments

@jmchilton
Copy link
Member

The comments say:

The WorkflowCard component props include:

    workflow: StoredWorkflowDetailed;

But the card is also used in the workflow editor which has slightly different properties - so I think this type needs to be generalized (unioned with whatever the workflow editor is using). I think those should be stubbed out as needed as interfaces on the client side and the WorkflowCard should be updated to consume either type.

The WorkflowCardList component takes in a Workflow[] array - where workflow is just defined as:

export type Workflow = Record<string, never>;

Again, I think we should stub what is needed on the client and clarify the different types of objects this consumes and have those types setup. This would unblock the vue-tsc work while we wait for backend model objects and it would help prioritize what backend objects are needed and what they should look like for the client.

These things together would cleanup the vue-tsc errors for these components but also properly clarify what the interface for these components really is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant