Skip to content
/ plugin-events Public

Commit 76848a5

Browse files
trashertrasher
committed
phpstan level 6, remove useless doc and params
1 parent ee7cf34 commit 76848a5

File tree

6 files changed

+46
-104
lines changed

6 files changed

+46
-104
lines changed

‎lib/GaletteEvents/Controllers/Crud/ActivitiesController.php‎

Lines changed: 11 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ class ActivitiesController extends AbstractPluginController
4949

5050
/**
5151
* Add page
52-
*
53-
* @param Request $request PSR Request
54-
* @param Response $response PSR Response
5552
*/
5653
public function add(Request $request, Response $response): Response
5754
{
@@ -60,9 +57,6 @@ public function add(Request $request, Response $response): Response
6057

6158
/**
6259
* Add action
63-
*
64-
* @param Request $request PSR Request
65-
* @param Response $response PSR Response
6660
*/
6761
public function doAdd(Request $request, Response $response): Response
6862
{
@@ -75,10 +69,8 @@ public function doAdd(Request $request, Response $response): Response
7569
/**
7670
* List page
7771
*
78-
* @param Request $request PSR Request
79-
* @param Response $response PSR Response
80-
* @param string|null $option One of 'page' or 'order'
81-
* @param string|int|null $value Value of the option
72+
* @param string|null $option One of 'page' or 'order'
73+
* @param string|int|null $value Value of the option
8274
*/
8375
public function list(Request $request, Response $response, ?string $option = null, string|int|null $value = null): Response
8476
{
@@ -124,9 +116,6 @@ public function list(Request $request, Response $response, ?string $option = nul
124116

125117
/**
126118
* Filtering
127-
*
128-
* @param Request $request PSR Request
129-
* @param Response $response PSR Response
130119
*/
131120
public function filter(Request $request, Response $response): Response
132121
{
@@ -160,10 +149,8 @@ public function filter(Request $request, Response $response): Response
160149
/**
161150
* Edit page
162151
*
163-
* @param Request $request PSR Request
164-
* @param Response $response PSR Response
165-
* @param int|null $id Model id
166-
* @param string $action Action
152+
* @param int|null $id Model id
153+
* @param string $action Action
167154
*/
168155
public function edit(Request $request, Response $response, ?int $id = null, string $action = 'edit'): Response
169156
{
@@ -204,10 +191,8 @@ public function edit(Request $request, Response $response, ?int $id = null, stri
204191
/**
205192
* Edit action
206193
*
207-
* @param Request $request PSR Request
208-
* @param Response $response PSR Response
209-
* @param null|int $id Model id for edit
210-
* @param string $action Either add or edit
194+
* @param null|int $id Model id for edit
195+
* @param string $action Either add or edit
211196
*/
212197
public function doEdit(Request $request, Response $response, ?int $id = null, string $action = 'edit'): Response
213198
{
@@ -292,7 +277,7 @@ public function doEdit(Request $request, Response $response, ?int $id = null, st
292277
/**
293278
* Get redirection URI
294279
*
295-
* @param array $args Route arguments
280+
* @param array<string,mixed> $args Route arguments
296281
*/
297282
public function redirectUri(array $args): string
298283
{
@@ -302,7 +287,7 @@ public function redirectUri(array $args): string
302287
/**
303288
* Get form URI
304289
*
305-
* @param array $args Route arguments
290+
* @param array<string,mixed> $args Route arguments
306291
*/
307292
public function formUri(array $args): string
308293
{
@@ -315,7 +300,7 @@ public function formUri(array $args): string
315300
/**
316301
* Get confirmation removal page title
317302
*
318-
* @param array $args Route arguments
303+
* @param array<string,mixed> $args Route arguments
319304
*/
320305
public function confirmRemoveTitle(array $args): string
321306
{
@@ -330,8 +315,8 @@ public function confirmRemoveTitle(array $args): string
330315
/**
331316
* Remove object
332317
*
333-
* @param array $args Route arguments
334-
* @param array $post POST values
318+
* @param array<string,mixed> $args Route arguments
319+
* @param array<string,mixed> $post POST values
335320
*/
336321
protected function doDelete(array $args, array $post): bool
337322
{

‎lib/GaletteEvents/Controllers/Crud/BookingsController.php‎

Lines changed: 18 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ class BookingsController extends AbstractPluginController
5656
/**
5757
* Add page
5858
*
59-
* @param Request $request PSR Request
60-
* @param Response $response PSR Response
61-
* @param int|null $id_adh Member id
59+
* @param int|null $id_adh Booking id
6260
*/
6361
public function add(Request $request, Response $response, ?int $id_adh = null): Response
6462
{
@@ -67,9 +65,6 @@ public function add(Request $request, Response $response, ?int $id_adh = null):
6765

6866
/**
6967
* Add action
70-
*
71-
* @param Request $request PSR Request
72-
* @param Response $response PSR Response
7368
*/
7469
public function doAdd(Request $request, Response $response): Response
7570
{
@@ -82,10 +77,8 @@ public function doAdd(Request $request, Response $response): Response
8277
/**
8378
* List page
8479
*
85-
* @param Request $request PSR Request
86-
* @param Response $response PSR Response
87-
* @param string|null $option One of 'page' or 'order'
88-
* @param string|int|null $value Value of the option
80+
* @param string|null $option One of 'page' or 'order'
81+
* @param string|int|null $value Value of the option
8982
*/
9083
public function list(Request $request, Response $response, ?string $option = null, string|int|null $value = null): Response
9184
{
@@ -96,13 +89,11 @@ public function list(Request $request, Response $response, ?string $option = nul
9689
/**
9790
* List page
9891
*
99-
* @param Request $request PSR Request
100-
* @param Response $response PSR Response
101-
* @param string|int $event Linked event. May be an event ID, 'all' or 'guess'.
102-
* @param string|null $option One of 'page' or 'order'
103-
* @param string|int|null $value Value of the option
92+
* @param string|int $event Linked event. May be an event ID, 'all' or 'guess'.
93+
* @param string|null $option One of 'page' or 'order'
94+
* @param string|int|null $value Value of the option
10495
*/
105-
public function listBookings(Request $request, Response $response, string|int $event, ?string $option = null, string|int|null $value = null): Response
96+
public function listBookings(Response $response, string|int $event, ?string $option = null, string|int|null $value = null): Response
10697
{
10798
$filters = $this->session->filter_bookings ?? new BookingsList();
10899

@@ -169,9 +160,6 @@ public function listBookings(Request $request, Response $response, string|int $e
169160

170161
/**
171162
* Filtering
172-
*
173-
* @param Request $request PSR Request
174-
* @param Response $response PSR Response
175163
*/
176164
public function filter(Request $request, Response $response): Response
177165
{
@@ -182,9 +170,7 @@ public function filter(Request $request, Response $response): Response
182170
/**
183171
* Filtering
184172
*
185-
* @param Request $request PSR Request
186-
* @param Response $response PSR Response
187-
* @param string|int $event Linked event. May be an event ID, 'all' or 'guess'.
173+
* @param string|int $event Linked event. May be an event ID, 'all' or 'guess'.
188174
*/
189175
public function filterBookings(Request $request, Response $response, string|int $event): Response
190176
{
@@ -242,9 +228,6 @@ public function filterBookings(Request $request, Response $response, string|int
242228

243229
/**
244230
* Batch actions handler
245-
*
246-
* @param Request $request PSR Request
247-
* @param Response $response PSR Response
248231
*/
249232
public function handleBatch(Request $request, Response $response): Response
250233
{
@@ -338,11 +321,9 @@ public function handleBatch(Request $request, Response $response): Response
338321
/**
339322
* Edit page
340323
*
341-
* @param Request $request PSR Request
342-
* @param Response $response PSR Response
343-
* @param int|null $id Model id
344-
* @param string $action Action
345-
* @param int|null $id_adh Member ID (for add)
324+
* @param int|null $id Model id
325+
* @param string $action Action
326+
* @param int|null $id_adh Member ID (for add)
346327
*/
347328
public function edit(Request $request, Response $response, ?int $id = null, string $action = 'edit', ?int $id_adh = null): Response
348329
{
@@ -443,10 +424,8 @@ public function edit(Request $request, Response $response, ?int $id = null, stri
443424
/**
444425
* Edit action
445426
*
446-
* @param Request $request PSR Request
447-
* @param Response $response PSR Response
448-
* @param null|int $id Model id for edit
449-
* @param string $action Either add or edit
427+
* @param null|int $id Model id for edit
428+
* @param string $action Either add or edit
450429
*/
451430
public function doEdit(Request $request, Response $response, ?int $id = null, string $action = 'edit'): Response
452431
{
@@ -567,7 +546,7 @@ public function doEdit(Request $request, Response $response, ?int $id = null, st
567546
/**
568547
* Get redirection URI
569548
*
570-
* @param array $args Route arguments
549+
* @param array<string,mixed> $args Route arguments
571550
*/
572551
public function redirectUri(array $args): string
573552
{
@@ -577,7 +556,7 @@ public function redirectUri(array $args): string
577556
/**
578557
* Get form URI
579558
*
580-
* @param array $args Route arguments
559+
* @param array<string,mixed> $args Route arguments
581560
*/
582561
public function formUri(array $args): string
583562
{
@@ -590,7 +569,7 @@ public function formUri(array $args): string
590569
/**
591570
* Get confirmation removal page title
592571
*
593-
* @param array $args Route arguments
572+
* @param array<string,mixed> $args Route arguments
594573
*/
595574
public function confirmRemoveTitle(array $args): string
596575
{
@@ -608,8 +587,8 @@ public function confirmRemoveTitle(array $args): string
608587
/**
609588
* Remove object
610589
*
611-
* @param array $args Route arguments
612-
* @param array $post POST values
590+
* @param array<string,mixed> $args Route arguments
591+
* @param array<string,mixed> $post POST values
613592
*/
614593
protected function doDelete(array $args, array $post): bool
615594
{

‎lib/GaletteEvents/Controllers/Crud/EventsController.php‎

Lines changed: 13 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,6 @@ class EventsController extends AbstractPluginController
5757

5858
/**
5959
* Add page
60-
*
61-
* @param Request $request PSR Request
62-
* @param Response $response PSR Response
6360
*/
6461
public function add(Request $request, Response $response): Response
6562
{
@@ -68,9 +65,6 @@ public function add(Request $request, Response $response): Response
6865

6966
/**
7067
* Add action
71-
*
72-
* @param Request $request PSR Request
73-
* @param Response $response PSR Response
7468
*/
7569
public function doAdd(Request $request, Response $response): Response
7670
{
@@ -83,10 +77,8 @@ public function doAdd(Request $request, Response $response): Response
8377
/**
8478
* List page
8579
*
86-
* @param Request $request PSR Request
87-
* @param Response $response PSR Response
88-
* @param string|null $option One of 'page' or 'order'
89-
* @param string|int|null $value Value of the option
80+
* @param string|null $option One of 'page' or 'order'
81+
* @param string|int|null $value Value of the option
9082
*/
9183
public function list(Request $request, Response $response, ?string $option = null, string|int|null $value = null): Response
9284
{
@@ -133,10 +125,8 @@ public function list(Request $request, Response $response, ?string $option = nul
133125
/**
134126
* Calendar view
135127
*
136-
* @param Request $request PSR Request
137-
* @param Response $response PSR Response
138-
* @param string|null $option One of 'page' or 'order'
139-
* @param string|int|null $value Value of the option
128+
* @param string|null $option One of 'page' or 'order'
129+
* @param string|int|null $value Value of the option
140130
*/
141131
public function calendar(
142132
Request $request,
@@ -195,9 +185,6 @@ public function calendar(
195185

196186
/**
197187
* Calendar view
198-
*
199-
* @param Request $request PSR Request
200-
* @param Response $response PSR Response
201188
*/
202189
public function ajaxCalendar(Request $request, Response $response): Response
203190
{
@@ -214,9 +201,6 @@ public function ajaxCalendar(Request $request, Response $response): Response
214201

215202
/**
216203
* Filtering
217-
*
218-
* @param Request $request PSR Request
219-
* @param Response $response PSR Response
220204
*/
221205
public function filter(Request $request, Response $response): Response
222206
{
@@ -250,10 +234,8 @@ public function filter(Request $request, Response $response): Response
250234
/**
251235
* Edit page
252236
*
253-
* @param Request $request PSR Request
254-
* @param Response $response PSR Response
255-
* @param int|null $id Model id
256-
* @param string $action Action
237+
* @param int|null $id Model id
238+
* @param string $action Action
257239
*/
258240
public function edit(Request $request, Response $response, ?int $id = null, string $action = 'edit'): Response
259241
{
@@ -316,10 +298,8 @@ public function edit(Request $request, Response $response, ?int $id = null, stri
316298
/**
317299
* Edit action
318300
*
319-
* @param Request $request PSR Request
320-
* @param Response $response PSR Response
321-
* @param null|int $id Model id for edit
322-
* @param string $action Either add or edit
301+
* @param null|int $id Model id for edit
302+
* @param string $action Either add or edit
323303
*/
324304
public function doEdit(Request $request, Response $response, ?int $id = null, string $action = 'edit'): Response
325305
{
@@ -448,7 +428,7 @@ public function doEdit(Request $request, Response $response, ?int $id = null, st
448428
/**
449429
* Get redirection URI
450430
*
451-
* @param array $args Route arguments
431+
* @param array<string,mixed> $args Route arguments
452432
*/
453433
public function redirectUri(array $args): string
454434
{
@@ -458,7 +438,7 @@ public function redirectUri(array $args): string
458438
/**
459439
* Get form URI
460440
*
461-
* @param array $args Route arguments
441+
* @param array<string,mixed> $args Route arguments
462442
*/
463443
public function formUri(array $args): string
464444
{
@@ -471,7 +451,7 @@ public function formUri(array $args): string
471451
/**
472452
* Get confirmation removal page title
473453
*
474-
* @param array $args Route arguments
454+
* @param array<string,mixed> $args Route arguments
475455
*/
476456
public function confirmRemoveTitle(array $args): string
477457
{
@@ -486,8 +466,8 @@ public function confirmRemoveTitle(array $args): string
486466
/**
487467
* Remove object
488468
*
489-
* @param array $args Route arguments
490-
* @param array $post POST values
469+
* @param array<string,mixed> $args Route arguments
470+
* @param array<string,mixed> $post POST values
491471
*/
492472
protected function doDelete(array $args, array $post): bool
493473
{

‎lib/GaletteEvents/Controllers/CsvController.php‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@ class CsvController extends \Galette\Controllers\CsvController
4141
/**
4242
* Bookings CSV exports
4343
*
44-
* @param Request $request PSR Request
45-
* @param Response $response PSR Response
46-
* @param ?int $id Event ID, if any
44+
* @param ?int $id Event ID, if any
4745
*/
4846
public function bookingsExport(Request $request, Response $response, ?int $id = null): Response
4947
{

0 commit comments

Comments
 (0)