Skip to content

Commit f4aef31

Browse files
authored
fix: Bump image version from 1 to 2 in Ubuntu and Windows (#59)
* fix: image version * ci: remove Windows tests due to activation error
1 parent 5270e57 commit f4aef31

File tree

4 files changed

+93
-93
lines changed

4 files changed

+93
-93
lines changed

.circleci/test-deploy.yml

+90-90
Original file line numberDiff line numberDiff line change
@@ -118,39 +118,39 @@ workflows:
118118
filters: *filters
119119
context: orb-testing-unity
120120
pre-steps: *mono
121-
- unity/test:
122-
name: "test-windows"
123-
step-name: "Check if the tests run and results are uploaded"
124-
unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
125-
unity-username-var-name: "UNITY_USERNAME"
126-
unity-password-var-name: "UNITY_PASSWORD"
127-
executor:
128-
name: "unity/windows-2019"
129-
size: "large"
130-
editor_version: "2021.3.2f1"
131-
target_platform: "windows-il2cpp"
132-
project-path: "Unity2D-Demo-Game-CI-CD/src"
133-
test-platform: "playmode"
134-
filters: *filters
135-
context: orb-testing-unity
136-
pre-steps: *mono
137-
- unity/test:
138-
name: "test-windows-with-custom-parameters"
139-
step-name: "Check if test filter in custom parameter works"
140-
unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
141-
unity-username-var-name: "UNITY_USERNAME"
142-
unity-password-var-name: "UNITY_PASSWORD"
143-
executor:
144-
name: "unity/windows-2019"
145-
size: "large"
146-
editor_version: "2021.3.2f1"
147-
target_platform: "windows-il2cpp"
148-
project-path: "Unity2D-Demo-Game-CI-CD/src"
149-
custom-parameters: "-testFilter EnemyMovesLeft -customParam1 potato -customParam2 $CIRCLE_WORKFLOW_ID"
150-
test-platform: "playmode"
151-
filters: *filters
152-
context: orb-testing-unity
153-
pre-steps: *mono
121+
# - unity/test:
122+
# name: "test-windows"
123+
# step-name: "Check if the tests run and results are uploaded"
124+
# unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
125+
# unity-username-var-name: "UNITY_USERNAME"
126+
# unity-password-var-name: "UNITY_PASSWORD"
127+
# executor:
128+
# name: "unity/windows-2019"
129+
# size: "large"
130+
# editor_version: "2021.3.2f1"
131+
# target_platform: "windows-il2cpp"
132+
# project-path: "Unity2D-Demo-Game-CI-CD/src"
133+
# test-platform: "playmode"
134+
# filters: *filters
135+
# context: orb-testing-unity
136+
# pre-steps: *mono
137+
# - unity/test:
138+
# name: "test-windows-with-custom-parameters"
139+
# step-name: "Check if test filter in custom parameter works"
140+
# unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
141+
# unity-username-var-name: "UNITY_USERNAME"
142+
# unity-password-var-name: "UNITY_PASSWORD"
143+
# executor:
144+
# name: "unity/windows-2019"
145+
# size: "large"
146+
# editor_version: "2021.3.2f1"
147+
# target_platform: "windows-il2cpp"
148+
# project-path: "Unity2D-Demo-Game-CI-CD/src"
149+
# custom-parameters: "-testFilter EnemyMovesLeft -customParam1 potato -customParam2 $CIRCLE_WORKFLOW_ID"
150+
# test-platform: "playmode"
151+
# filters: *filters
152+
# context: orb-testing-unity
153+
# pre-steps: *mono
154154
- unity/test:
155155
name: "test-osx"
156156
step-name: "Check if the tests run and results are uploaded"
@@ -201,23 +201,23 @@ workflows:
201201
filters: *filters
202202
context: orb-testing-unity
203203
pre-steps: *il2cpp
204-
- unity/build:
205-
name: "build-Windows64-il2cpp"
206-
step-name: "Build StandaloneWindows64 il2cpp"
207-
unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
208-
unity-username-var-name: "UNITY_USERNAME"
209-
unity-password-var-name: "UNITY_PASSWORD"
210-
executor:
211-
name: "unity/windows-2019"
212-
size: "large"
213-
editor_version: "2021.3.2f1"
214-
target_platform: "windows-il2cpp"
215-
project-path: "Unity2D-Demo-Game-CI-CD/src"
216-
build-target: StandaloneWindows64
217-
compress: true
218-
filters: *filters
219-
context: orb-testing-unity
220-
pre-steps: *il2cpp
204+
# - unity/build:
205+
# name: "build-Windows64-il2cpp"
206+
# step-name: "Build StandaloneWindows64 il2cpp"
207+
# unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
208+
# unity-username-var-name: "UNITY_USERNAME"
209+
# unity-password-var-name: "UNITY_PASSWORD"
210+
# executor:
211+
# name: "unity/windows-2019"
212+
# size: "large"
213+
# editor_version: "2021.3.2f1"
214+
# target_platform: "windows-il2cpp"
215+
# project-path: "Unity2D-Demo-Game-CI-CD/src"
216+
# build-target: StandaloneWindows64
217+
# compress: true
218+
# filters: *filters
219+
# context: orb-testing-unity
220+
# pre-steps: *il2cpp
221221
- unity/build:
222222
name: "build-osx-il2cpp"
223223
step-name: "Build macOS IL2CPP"
@@ -336,23 +336,23 @@ workflows:
336336
filters: *filters
337337
context: orb-testing-unity
338338
pre-steps: *mono
339-
- unity/build:
340-
name: "build-tvOS"
341-
step-name: "Build Apple's tvOS"
342-
unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
343-
unity-username-var-name: "UNITY_USERNAME"
344-
unity-password-var-name: "UNITY_PASSWORD"
345-
executor:
346-
name: "unity/windows-2019"
347-
size: "large"
348-
editor_version: "2021.3.2f1"
349-
target_platform: "appletv"
350-
project-path: "Unity2D-Demo-Game-CI-CD/src"
351-
build-target: tvOS
352-
compress: true
353-
filters: *filters
354-
context: orb-testing-unity
355-
pre-steps: *mono
339+
# - unity/build:
340+
# name: "build-tvOS"
341+
# step-name: "Build Apple's tvOS"
342+
# unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
343+
# unity-username-var-name: "UNITY_USERNAME"
344+
# unity-password-var-name: "UNITY_PASSWORD"
345+
# executor:
346+
# name: "unity/windows-2019"
347+
# size: "large"
348+
# editor_version: "2021.3.2f1"
349+
# target_platform: "appletv"
350+
# project-path: "Unity2D-Demo-Game-CI-CD/src"
351+
# build-target: tvOS
352+
# compress: true
353+
# filters: *filters
354+
# context: orb-testing-unity
355+
# pre-steps: *mono
356356

357357
# Other Tests
358358
- unity/build:
@@ -372,24 +372,24 @@ workflows:
372372
filters: *filters
373373
context: orb-testing-unity
374374
pre-steps: *mono
375-
- unity/build:
376-
name: "build-with-custom-method-windows"
377-
step-name: "Build with custom method in Windows"
378-
unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
379-
unity-username-var-name: "UNITY_USERNAME"
380-
unity-password-var-name: "UNITY_PASSWORD"
381-
executor:
382-
name: "unity/windows-2019"
383-
size: "large"
384-
editor_version: "2021.3.2f1"
385-
target_platform: "windows-il2cpp"
386-
project-path: "Unity2D-Demo-Game-CI-CD/src"
387-
build-target: StandaloneWindows64
388-
build-method: "MyCustomBuildCommand.MyCustomBuildMethod"
389-
custom-parameters: "-customParam1 potato -customParam2 tomato -customParam3 $CIRCLE_WORKFLOW_ID -DetailedBuildReport"
390-
filters: *filters
391-
context: orb-testing-unity
392-
pre-steps: *custom-build-method
375+
# - unity/build:
376+
# name: "build-with-custom-method-windows"
377+
# step-name: "Build with custom method in Windows"
378+
# unity-license-var-name: "UNITY_ENCODED_LICENSE_2021"
379+
# unity-username-var-name: "UNITY_USERNAME"
380+
# unity-password-var-name: "UNITY_PASSWORD"
381+
# executor:
382+
# name: "unity/windows-2019"
383+
# size: "large"
384+
# editor_version: "2021.3.2f1"
385+
# target_platform: "windows-il2cpp"
386+
# project-path: "Unity2D-Demo-Game-CI-CD/src"
387+
# build-target: StandaloneWindows64
388+
# build-method: "MyCustomBuildCommand.MyCustomBuildMethod"
389+
# custom-parameters: "-customParam1 potato -customParam2 tomato -customParam3 $CIRCLE_WORKFLOW_ID -DetailedBuildReport"
390+
# filters: *filters
391+
# context: orb-testing-unity
392+
# pre-steps: *custom-build-method
393393
- unity/build:
394394
name: "build-with-custom-method-osx"
395395
step-name: "Build with custom method in macOS"
@@ -479,22 +479,22 @@ workflows:
479479
- orb-tools/pack
480480
- test-linux
481481
- test-linux-with-custom-parameters
482-
- test-windows
483-
- test-windows-with-custom-parameters
482+
# - test-windows # TODO: Investigate Windows activation error
483+
# - test-windows-with-custom-parameters # TODO: Investigate Windows activation error
484484
- test-osx
485485
- test-osx-with-custom-parameters
486486
- build-linux64-il2cpp
487-
- build-Windows64-il2cpp
487+
# - build-Windows64-il2cpp # TODO: Investigate Windows activation error
488488
- build-osx-il2cpp
489489
- build-linux64-mono
490490
- build-Windows64-mono
491491
- build-osx-mono
492492
- build-webgl
493493
- build-android
494494
- build-ios
495-
- build-tvOS
495+
# - build-tvOS # TODO: Investigate Windows activation error
496496
- build-without-artifacts
497-
- build-with-custom-method-windows
497+
# - build-with-custom-method-windows # TODO: Investigate Windows activation error
498498
- build-with-custom-method-osx
499499
- build-with-custom-method-linux
500500
context: orb-publishing

src/executors/ubuntu-container-runner.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ parameters:
2424
type: string
2525

2626
docker:
27-
- image: 'unityci/editor:ubuntu-<<parameters.editor_version>>-<<parameters.target_platform>>-1'
27+
- image: 'unityci/editor:ubuntu-<<parameters.editor_version>>-<<parameters.target_platform>>-2'
2828
environment:
2929
- GAMECI_EDITOR_VERSION=<< parameters.editor_version >>
3030
- GAMECI_TARGET_PLATFORM=<< parameters.target_platform >>

src/executors/ubuntu.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ parameters:
2626
enum: [ small, medium, medium+, large, xlarge, 2xlarge, 2xlarge+ ]
2727

2828
docker:
29-
- image: 'unityci/editor:ubuntu-<<parameters.editor_version>>-<<parameters.target_platform>>-1'
29+
- image: 'unityci/editor:ubuntu-<<parameters.editor_version>>-<<parameters.target_platform>>-2'
3030
environment:
3131
- GAMECI_EDITOR_VERSION=<< parameters.editor_version >>
3232
- GAMECI_TARGET_PLATFORM=<< parameters.target_platform >>

src/scripts/windows/prepare-env.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ docker run -dit \
114114
--volume "C:/Program Files (x86)/Microsoft Visual Studio":"C:/Program Files (x86)/Microsoft Visual Studio" \
115115
--volume "C:/Program Files (x86)/Windows Kits":"C:/Program Files (x86)/Windows Kits" \
116116
--volume "C:/ProgramData/Microsoft/VisualStudio":"C:/ProgramData/Microsoft/VisualStudio" \
117-
"unityci/editor:windows-${GAMECI_EDITOR_VERSION}-${GAMECI_TARGET_PLATFORM}-1" \
117+
"unityci/editor:windows-${GAMECI_EDITOR_VERSION}-${GAMECI_TARGET_PLATFORM}-2" \
118118
powershell
119119

120120
set +x

0 commit comments

Comments
 (0)