Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests to allow publication of a hotfix release #87

Closed
GabLeRoux opened this issue Nov 25, 2024 · 4 comments
Closed

Fix the tests to allow publication of a hotfix release #87

GabLeRoux opened this issue Nov 25, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@GabLeRoux
Copy link
Member

As I suspected, the release needs to have the tests passing (which is a good thing). But the orb's secret aren't in sync anymore with what's being tested (due to work in progress to get activation support properly working with #83).

I created a release mainly to publish the changes from #82 and unblock some workflows using this action, but it can't be done until the complete workflow passes. Only then the orb publication will work:

CleanShot 2024-11-25 at 18 26 29@2x

I will see what I can do with the secrets. I think having a combination of older env vars and the new env var should get a few jobs passing.

@GabLeRoux GabLeRoux added the bug Something isn't working label Nov 25, 2024
@GabLeRoux
Copy link
Member Author

GabLeRoux commented Nov 25, 2024

I've added UNITY_USERNAME again in the workflow env vars (I did remove it as part of #83). I triggered the workflows again. We'll see where it gets us.

Edit: still failing:

CleanShot 2024-11-25 at 18 44 29@2x

Detected OS: Linux.
++ xvfb-run --auto-servernum '--server-args=-screen 0 640x480x24' unity-editor -projectPath /root/project/Unity2D-Demo-Game-CI-CD/src -runTests -testPlatform playmode -testResults /root/project/Unity2D-Demo-Game-CI-CD/src/playmode-results.xml -logFile /dev/stdout -batchmode -nographics -enableCodeCoverage -coverageResultsPath /root/project/Unity2D-Demo-Game-CI-CD/src/playmode-coverage -coverageOptions 'generateAdditionalMetrics;generateHtmlReport;generateHtmlReportHistory;generateBadgeReport;' -debugCodeOptimization
Unity Editor version:    2022.3.33f1 (b2c853adf198)
Branch:                  2022.3/staging
Build type:              Release
Batch mode:              YES
System name:             Linux
Distro version:          #63~20.04.1-Ubuntu SMP Mon Mar 25 10:28:36 UTC 2024
Kernel version:          5.15.0-1057-aws
Architecture:            x86_64
Available memory:        70213 MB
[Licensing::Module] Trying to connect to existing licensing client channel...
[Licensing::IpcConnector] Connection attempt to the License Client on channel: "LicenseClient-root" failed because channel doesn't exist; code: "0x80000002"
[Licensing::Module] Successfully launched the LicensingClient (PId: 207)
[Licensing::IpcConnector] Successfully connected to the License Client on channel: "LicenseClient-root" at "2024-11-25T23:44:29.842426Z"
[SignatureVerifier] Application signature verification not supported on this platform.
[Licensing::Client] Handshaking with LicensingClient:
  Version:                 1.15.4+eee609c
  Session Id:              f91873b2b27d49f0837ef3d7962e1c20
  Correlation Id:          0b80a79ada160331dcfc459be43a2cb8
  External correlation Id: 2405689163348686445
  Machine Id:              D7nTUnjNAmtsUMcnoyrqkgIbYdM=
[Licensing::Module] Successfully connected to LicensingClient on channel: "LicenseClient-root" (connect: 0.67s, validation: 0.05s, handshake: 0.00s)
[Licensing::IpcConnector] Successfully connected to the License Notification on channel: "LicenseClient-root-notifications" at "2024-11-25T23:44:29.894139Z"
[Licensing::Module] Connected to LicensingClient (PId: 207, launch time: 0.00, total connection time: 0.72s)
[Licensing::Module] Error: Access token is unavailable; failed to update
[Licensing::Client] Successfully updated license
[Licensing::Client] Successfully resolved entitlements
[Licensing::Module] Error: License is not active (com.unity.editor.headless). HasEntitlements will fail.
Pro License: NO
Initialize udev device monitor.
No valid Unity Editor license found. Please activate your license.

Exited with code exit status 1

Most of them are failing with this.

Edit: I deleted the UNITY_USERNAME again (as solving the activation problem was much harder)

@GabLeRoux
Copy link
Member Author

I will skip the tests and only run the orb publishing for now. Can't be worst than a not working at all solution anyway 🤷

@GabLeRoux
Copy link
Member Author

For now, I managed to publish a hotfix version of the orb. I'll wait for feedback (I don't expect much).

CleanShot 2024-11-25 at 19 03 32@2x

Good news is we will be able to move forward with this project 👍

@GabLeRoux
Copy link
Member Author

GabLeRoux commented Nov 26, 2024

Closing this issue as I created a branch, commented out the tests and related jobs only to keep the orb-tools/pack and orb-tools/publish as shown in https://github.com/game-ci/unity-orb/releases/tag/v1.7.1

Full Changelog: v1.7.0...v1.7.1

Closing this issue. It's not really fixed, but the main idea was to publish a hotfix, which worked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant