Skip to content

Is it possible to use non base editor image? #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lvgrecords opened this issue Jan 11, 2021 · 3 comments
Closed

Is it possible to use non base editor image? #89

lvgrecords opened this issue Jan 11, 2021 · 3 comments

Comments

@lvgrecords
Copy link

lvgrecords commented Jan 11, 2021

I'm trying to use 2020.1.17f1-ios-0 but getting an error below:

Run webbertakken/[email protected]
/usr/bin/docker build /home/lvg/actions-runner/_work/_actions/webbertakken/unity-test-runner/v2.0-alpha-1/action --file /home/lvg/actions-runner/_work/_actions/webbertakken/unity-test-runner/v2.0-alpha-1/action/Dockerfile --build-arg IMAGE=unityci/editor:2020.1.17f1-ios-0-base-0 --tag unity-action:2020.1.17f1-ios-0-base-0
Sending build context to Docker daemon  144.4kB

Step 1/14 : ARG IMAGE
Step 2/14 : FROM $IMAGE
manifest for unityci/editor:2020.1.17f1-ios-0-base-0 not found: manifest unknown: manifest unknown
Error: The process '/usr/bin/docker' failed with exit code 1

My workflow:

name: Continuous Integration

on:
  pull_request: { }
  push: { branches: [ master ] }

env:
  UNITY_LICENSE: ${{ secrets.UNITY_LICENSE }}
  UNITY_VERSION: 2020.1.17f1-ios-0

jobs:
  unit-tests:
    name: Unit Tests
    #    runs-on: ubuntu-20.04
    runs-on: self-hosted
    steps:
      - name: cleanup #https://github.com/actions/checkout/issues/211
        run: |
          sudo chown -R $USER:$USER $GITHUB_WORKSPACE
      - name: Checkout repository
        uses: actions/checkout@v2
      - uses: actions/[email protected]
        with:
          path: Library
          key: Library
      - name: Run tests
        id: testRunner
        uses: webbertakken/[email protected]
        with:
          unityVersion: ${{ env.UNITY_VERSION }}
      - uses: actions/upload-artifact@v1
        with:
          name: Test results (all modes)
          path: ${{ steps.testRunner.outputs.artifactsPath }}

Looks -base-0 is added on runtime. Are there ability to use editor+modules based docker images eg 2020.1.17f1-ios-0?
Unfortunately using it's a required workaround for googlesamples/unity-jar-resolver#412

In case it's not supported at that moment I do not mind to add such support myself by PR

@webbertakken
Copy link
Member

No and yes. In builder you can specify targetPlatform. This functionality has yet to be ported to test runner (contributions welcomed).

In the mean time you will be able to use customImage as described in the docs

@lvgrecords
Copy link
Author

lvgrecords commented Jan 11, 2021

In the mean time you will be able to use customImage as described in the docs

looks webbertakken/[email protected] version do not recognise customImage properly - it always set unity version 2019.2.11f1, assume it's fallback version
but webbertakken/unity-test-runner@main (that docs recommends) downloads docker image specified on customImage property
would be nice to use exact version for that instead of branch head that could change any time

@webbertakken do u have any high level roadmap?

@webbertakken
Copy link
Member

I just created a release for v2.0-alpha-2 that you can use.

There is a high level roadmap, which is being discussed in discord mostly. We don't have an overarching infographic for this right now, as one of the main pointers is to use the new images, which we're working hard to start using for all target platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants