Fix PEP8 style failures

Author: lresende

setup.cfg

@@ -4,3 +4,21 @@ universal=1
 [metadata]
 description-file=README.rst
 license_file = LICENSE
+
+[flake8]
+# References:
+# https://flake8.readthedocs.io/en/latest/user/configuration.html
+# https://flake8.readthedocs.io/en/latest/user/error-codes.html
+exclude = __init__.py
+ignore =
+    # Import formatting
+    E4,
+    # Comparing types instead of isinstance
+    E721,
+    # Assigning lambda expression
+    E731,
+    # Ambiguous variable names
+    E741,
+    # Allow breaks after binary operators
+    W504
+max-line-length = 120

tests/__init__.py

@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
 try:
-    from unittest2 import TestCase
+    from unittest2 import TestCase # NOQA
 except ImportError:
-    from unittest import TestCase
+    from unittest import TestCase # NOQA

tests/test_application_master.py

@@ -61,4 +61,5 @@ def test_task_attempt(self, request_mock):
 
     def test_task_attempt_counters(self, request_mock):
         self.app.task_attempt_counters('app_1', 'job_2', 'task_3', 'attempt_4')
-        request_mock.assert_called_with('/proxy/app_1/ws/v1/mapreduce/jobs/job_2/tasks/task_3/attempt/attempt_4/counters')
+        request_mock.assert_called_with(
+            '/proxy/app_1/ws/v1/mapreduce/jobs/job_2/tasks/task_3/attempt/attempt_4/counters')

tests/test_base.py

@@ -1,11 +1,10 @@
 # -*- coding: utf-8 -*-
 try:
-    from httplib import OK
+    from httplib import OK # NOQA
 except ImportError:
-    from http.client import OK
+    from http.client import OK # NOQA
 
 import json
-import requests
 import requests_mock
 
 from tests import TestCase
@@ -17,7 +16,7 @@ class BaseYarnAPITestCase(TestCase):
     @staticmethod
     def success_response():
         return {
-            'status':'success'
+            'status': 'success'
         }
 
     def test_valid_request(self):
@@ -30,7 +29,6 @@ def test_valid_request(self):
             assert requests_get_mock.called
             self.assertIn(response.data['status'], 'success')
 
-
     def test_valid_request_with_parameters(self):
         with requests_mock.mock() as requests_get_mock:
             requests_get_mock.get('/ololo?foo=bar', text=json.dumps(BaseYarnAPITestCase.success_response()))

tests/test_hadoop_conf.py

@@ -12,11 +12,11 @@
 _http_getresponse_method = ''
 
 try:
-    from httplib import HTTPConnection, OK, NOT_FOUND
+    from httplib import HTTPConnection, OK, NOT_FOUND # NOQA
     _http_request_method = 'httplib.HTTPConnection.request'
     _http_getresponse_method = 'httplib.HTTPConnection.getresponse'
 except ImportError:
-    from http.client import HTTPConnection, OK, NOT_FOUND
+    from http.client import HTTPConnection, OK, NOT_FOUND # NOQA
     _http_request_method = 'http.client.HTTPConnection.request'
     _http_getresponse_method = 'http.client.HTTPConnection.getresponse'
 
@@ -118,10 +118,10 @@ def getheader(self, header_key, default_return):
         http_getresponse_mock.return_value = ResponseMock(OK, {})
         self.assertTrue(hadoop_conf._check_is_active_rm('example2', '8022'))
         http_getresponse_mock.reset_mock()
-        http_getresponse_mock.return_value = ResponseMock(OK, {'Refresh':"testing"})
+        http_getresponse_mock.return_value = ResponseMock(OK, {'Refresh': "testing"})
         self.assertFalse(hadoop_conf._check_is_active_rm('example2', '8022'))
         http_getresponse_mock.reset_mock()
-        http_getresponse_mock.return_value = ResponseMock(NOT_FOUND, {'Refresh':"testing"})
+        http_getresponse_mock.return_value = ResponseMock(NOT_FOUND, {'Refresh': "testing"})
         self.assertFalse(hadoop_conf._check_is_active_rm('example2', '8022'))
         http_conn_request_mock.side_effect = Exception('error')
         http_conn_request_mock.reset_mock()
@@ -136,14 +136,12 @@ def test_get_resource_manager(self):
             host_port = hadoop_conf._get_resource_manager(hadoop_conf.CONF_DIR, None)
 
             self.assertEqual(('example.com', '8022'), host_port)
-            parse_mock.assert_called_with('/etc/hadoop/conf/yarn-site.xml',
-                    'yarn.resourcemanager.webapp.address')
+            parse_mock.assert_called_with('/etc/hadoop/conf/yarn-site.xml', 'yarn.resourcemanager.webapp.address')
 
             host_port = hadoop_conf._get_resource_manager(hadoop_conf.CONF_DIR, 'rm1')
 
             self.assertEqual(('example.com', '8022'), host_port)
-            parse_mock.assert_called_with('/etc/hadoop/conf/yarn-site.xml',
-                    'yarn.resourcemanager.webapp.address.rm1')
+            parse_mock.assert_called_with('/etc/hadoop/conf/yarn-site.xml', 'yarn.resourcemanager.webapp.address.rm1')
 
             parse_mock.reset_mock()
             parse_mock.return_value = None

tests/test_main.py

@@ -1,5 +1,4 @@
 # -*- coding: utf-8 -*-
-from mock import patch, PropertyMock
 from tests import TestCase
 
 import yarn_api_client.main as m