Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various clarifications for inclusion as external libs #9

Open
jnorthrup opened this issue Aug 10, 2017 · 0 comments
Open

various clarifications for inclusion as external libs #9

jnorthrup opened this issue Aug 10, 2017 · 0 comments

Comments

@jnorthrup
Copy link

I just googled for a Kotlin Stack class and found this library...

i'd like to open this up for discussion:

things that are currently undefined:

no POM -- was there ever any intent or success with:
git submodule add https://github.com/<User>/Kotlin-Algorithm.git
?

no packages declared in the kotlin source -- curious things happen with root package in jvm

no README declaration of whether this lib attempts pure java or js stdlib -- inconsistent due to:

junit imports in the same hierarchy as the source code -- tests are nice... but this lib is inconsistent.

i'd like to use the simple Stack class and go back to playing with my own project... but my inclination is to suggest one of the active maintainers provide one or more or pom, gradle, and raw git submodule imports, with package hierarchy chosen ... git submodule add "Kotlin-Algorithm" into src/main/kotlin does not imply a pleasant packagename, but there's no reason it could not be robust as a git submodule.

for now i'm fine cutting and pasting these gems, but had to scratch my head a minute to figure out what is going on, an unexpected cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant