Skip to content

Commit 819155b

Browse files
committed
Fixed a build error by changing the branch cmake downloads googletest from master to main.
1 parent d9fb816 commit 819155b

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
66
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
77

8+
## [v2.2.1] - 2021-12-06
9+
10+
- Fixed a build error by changing the branch cmake downloads googletest from master to main.
11+
12+
## [v2.2.0] - 2021-12-03
13+
14+
- ReadBinary() and WriteBinary() added to read/write raw data, instead of having to use strings (thanks to @RolandHughes for adding this).
15+
816
## [v2.1.2] - 2021-07-01
917

1018
- Removed download of gtest if tests are not built.

CMakeLists.txt.in

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ project(googletest-download NONE)
55
include(ExternalProject)
66
ExternalProject_Add(googletest
77
GIT_REPOSITORY https://github.com/google/googletest.git
8-
GIT_TAG master
8+
GIT_TAG main
99
SOURCE_DIR "${CMAKE_BINARY_DIR}/googletest-src"
1010
BINARY_DIR "${CMAKE_BINARY_DIR}/googletest-build"
1111
CONFIGURE_COMMAND ""

README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Library for communicating with COM ports on a Linux system.
1010

1111
* Simple API
1212
* Supports custom baud rates
13-
* cmake based build system
13+
* `cmake` based build system
1414

1515
## Installation
1616

@@ -51,13 +51,13 @@ Library for communicating with COM ports on a Linux system.
5151
$ sudo make install
5252
```
5353

54-
1. To run the unit tests (NOTE: because this uses virtual serial ports via `stty`, this only works on Linux!):
54+
1. To run the unit tests:
5555

5656
```bash
5757
$ make run_unit_tests
5858
```
5959

60-
If you get errors such as `Could not open device /dev/ttyS10. Is the device name correct and do you have read/write permission?" thrown in the test fixture's constructor.`, it is probably an issue with either creating the virtual serial ports or permissions to access them.
60+
NOTE: The unit tests used to use virtual serial ports via `stty` on Linux to do more through testing. I ran into permission problems running stty on TravisCI after they did an update and had to remove tests (leaving almost no tests remaining). If anyone wants to add better unit tests, it is greatly welcomed!
6161

6262
## Examples
6363

@@ -73,7 +73,7 @@ int main() {
7373
serialPort.SetTimeout(-1); // Block when reading until any data is received
7474
serialPort.Open();
7575

76-
// Write some ASCII datae
76+
// Write some ASCII data
7777
serialPort.Write("Hello");
7878

7979
// Read some data back (will block until at least 1 byte is received due to the SetTimeout(-1) call above)
@@ -103,4 +103,4 @@ See GitHub Issues.
103103

104104
## Changelog
105105

106-
See CHANGELOG.md.
106+
See CHANGELOG.md.

0 commit comments

Comments
 (0)