Commit e4d3872
Skip RES HBM tests when op absent in OSS wheel (pytorch#6233)
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/3120
The RES (raw embedding streaming) HBM-lane tests in res_enabled_tables_test.py
reach torch.ops.fbgemm.masked_index_select, which is registered in the SSD
split-embeddings-cache extension (src/ssd_split_embeddings_cache/). That
directory is compiled only by the internal Buck build; the OSS CMake wheel
excludes it entirely, so the op is absent in OSS. Every HBM-lane test therefore
dies on an _OpNamespace lookup ("'fbgemm' object has no attribute
'masked_index_select'"), plus cascading _res_* attribute errors, turning the
OSS 'main' GPU CI red (30 failed / 13 passed).
Guard the single chokepoint all HBM-lane tests construct through
(_build_mixed_tbe, reached directly and via _drain_tbe/_device_tbe) with a
SkipTest when masked_index_select is not registered in the running wheel. On any
build that has the op (internal, and OSS once the extension is shipped) the guard
is a no-op and all tests run unchanged. The non-HBM allowlist tests use
_build_tbe, never touch the op, and continue to run everywhere.
This is the fast unblock for OSS trunk/nightly. The proper long-term fix is to
add src/ssd_split_embeddings_cache/ to the OSS CMake build so the op is present.
Reviewed By: FriedCosey
Differential Revision: D1177509281 parent f4e32f8 commit e4d3872
1 file changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
36 | 49 | | |
37 | 50 | | |
38 | 51 | | |
| |||
123 | 136 | | |
124 | 137 | | |
125 | 138 | | |
| 139 | + | |
| 140 | + | |
126 | 141 | | |
127 | 142 | | |
128 | 143 | | |
| |||
0 commit comments