Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ethexe): Introduce centralized event broadcasting system for services #4503

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(ethexe): Introduce centralized event broadcasting system for services #4503

wants to merge 1 commit into from

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Feb 10, 2025

Resolves #4483

Status: W.I.P, this code works but needs refactoring to make public API better to use. In particular I am unsure how to get rid of from_broadcaster function in tests.

@playX18 playX18 added the A1-inprogress Issue is in progress or PR draft is not ready to be reviewed label Feb 10, 2025
@playX18 playX18 self-assigned this Feb 10, 2025
breathx
breathx requested changes Feb 10, 2025
View reviewed changes
Copy link
Member

@breathx breathx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DMed about keeping observer service stream. Nodes broadcast should be added independently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breathx breathx breathx requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@playX18 playX18

Labels
A1-inprogress Issue is in progress or PR draft is not ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(ethexe): Add events from all services and send them to desired output channel
2 participants
@playX18 @breathx