Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ethexe): Add events from all services and send them to desired output channel #4483

Open
playX18 opened this issue Jan 30, 2025 · 0 comments · May be fixed by #4503
Open

refactor(ethexe): Add events from all services and send them to desired output channel #4483

playX18 opened this issue Jan 30, 2025 · 0 comments · May be fixed by #4503
Assignees
@playX18
Labels
C2-refactoring Refactoring proposal

Comments

@playX18
Copy link
Member

playX18 commented Jan 30, 2025

File Location(s)

No response

Proposal

At the moment testing code uses timeouts. If we have a way to receive events from all services we can simply wait for event to be received instead of waiting.

For example instead of sleep(Duration::from_secs(1)) in start_service (ethexe/service/src/tests.rs#L1648) we can simply wait for Event::Started to be produced.

How to achieve

  • Collect all possible events from all services into single enum
  • Introduce an output channel for producing events into it.
@playX18 playX18 added the C2-refactoring Refactoring proposal label Jan 30, 2025
@playX18 playX18 self-assigned this Jan 30, 2025
@playX18 playX18 linked a pull request Feb 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@playX18 playX18

Labels
C2-refactoring Refactoring proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ethexe): Introduce centralized event broadcasting system for services gear-tech/gear
1 participant
@playX18