Skip to content

fix(ethexe-consensus): batch commitment lost when new head arrives during WaitingAnnounceComputed #5342

@ukint-vs

Description

@ukint-vs

Problem

When a new ETH block arrives while the producer is in WaitingAnnounceComputed (computing a mini-announce), DefaultProcessing::new_head transitions to Initial without creating a batch commitment for the current block.

Block-specific items (codes_queue, validator updates, rewards) are only aggregated during BatchCommitmentManager::create_batch_commitment. Chain transitions are recoverable via collect_not_committed_predecessors, but these block-scoped commitments are silently lost.

Context

Pre-existing behavior (existed before mini-announces), but mini-announces widen the window since the producer spends more time cycling through WaitingAnnounceComputed → ReadyForMiniAnnounce.

Documented as TODO at ethexe/consensus/src/validator/producer.rs:166.

Fix options

  • Override process_new_head for WaitingAnnounceComputed to trigger AggregateBatchCommitment with next_block saved (same pattern as ReadyForMiniAnnounce)
  • Accept the current behavior since collect_not_committed_predecessors provides partial recovery

Related

PR #5321 (mini-announces)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions