Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always Log FM Query to clockwork #73

Closed
kostaszazim opened this issue Jul 7, 2024 · 3 comments
Closed

Always Log FM Query to clockwork #73

kostaszazim opened this issue Jul 7, 2024 · 3 comments

Comments

@kostaszazim
Copy link
Contributor

Hi! in src/Services/FileMakerConnection.php would that be possible to move line 744 after line 721 in order to always fire the QueryExecuted event? This should log the query to clockwork even with no results returned. Because now if you get back no results nothing is logged to clockwork and it is difficult to debug the actual query made to filemaker Data API.
@Smef
Copy link
Member

Smef commented Jul 8, 2024

We've actually had some discussions about this internally already. We may add something in there or put a slightly different response in the log when there's an error like that.

@Smef
Copy link
Member

Smef commented Jul 30, 2024

PR: #77

@Smef Smef closed this as completed Aug 30, 2024
@Smef
Copy link
Member

Smef commented Aug 30, 2024

Merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Smef @kostaszazim