Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes working my way through the book #103

Open
Xaeco opened this issue Dec 15, 2021 · 2 comments
Open

Notes working my way through the book #103

Xaeco opened this issue Dec 15, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@Xaeco
Copy link

Xaeco commented Dec 15, 2021

Chapter 1

Under Building Hello Go on page 23
The second curl example is incorrect

curl localhost:8180
Hello, you requested: /test

should be

curl localhost:8180/test
Hello, you requested: /test

Under Building the Hello Go container in Minikube on page 28
The link at the bottom returns 404:
https://minikube.sigs.k8s.io/docs/start/linux/

On page 29

$ eval $(minikube docker-env)

but in Windows it's

@FOR /f "tokens=*" %i IN ('minikube -p minikube docker-env') DO @%i

possibly suggest minikube docker-env to get the command relevant to your OS.

@Xaeco Xaeco changed the title Building Hello Go - curl example incorrect Notes walking through the book Dec 15, 2021
@Xaeco Xaeco changed the title Notes walking through the book Notes working my way through the book Dec 15, 2021
@geerlingguy geerlingguy added the bug Something isn't working label Dec 15, 2021
@geerlingguy
Copy link
Owner

Marking that first issue as a bug—for the second, what syntax is that? If PowerShell, I explicitly don't directly support PowerShell in all my examples. I often recommend WSL2 just because it would be incredibly painful to try to match all commands between Windows/PowerShell and [everything else].

@Xaeco
Copy link
Author

Xaeco commented Dec 15, 2021

Yeah it's Windows command line. My WSL2 was broken so I installed the Windows ver alongside my windows ver of Docker desktop and had this issue. I think using Minikube docker-env is quite nice as it outputs the right command for the user's OS. I guess it depends if it's worth it given this shouldn't happen in WSL2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants