Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more robust when a resource (author) is not available #32

Closed
cnuke opened this issue Nov 29, 2023 · 5 comments
Closed

Be more robust when a resource (author) is not available #32

cnuke opened this issue Nov 29, 2023 · 5 comments

Comments

@cnuke
Copy link
Member

cnuke commented Nov 29, 2023

While recently adding a new author to the genodians.org appliance I noticed that some resources were temporarily not available. In this case the fetchurl exits with an error and the download step is triggered again (due to the way the sequence component that orchestrates the steps is configured I assume *), which in turn leads to not updating the website with new posts for this duration.

The following commits address this problem by allowing fetchurl to ignore any failures in its reporting and the Genodians.org's Makefile to ignore incomplete authors.

*) I have not checked yet if we can get a similar result by solely changing how the scenario operates.
cnuke added a commit to cnuke/genodians.org that referenced this issue Nov 29, 2023
@cnuke
Be more robust when an author is not available
6c35da9 
Treat the case where the genodians archive of given author cannot
be accessed as a mere inconvience (by ignoring this author) rather
than an error that influence the complete appliance (by postponing
new posts by other authors potentially indefinitely).

Issue genodelabs#32.
cnuke added a commit to cnuke/genode that referenced this issue Nov 29, 2023
@cnuke
fetchurl: add 'ignore_failures' option
09ade3c 
This option is useful in cases where batching is configured and
failing to fetch a resource should not influence the over-all
result.

Issue genodelabs/genodians.org#32.
@nfeske
Copy link
Member

nfeske commented Nov 29, 2023

That looks good to me. Thanks for carrying this forward. It matches exactly what I remembered from our recent conversation.

@nfeske
Copy link
Member

nfeske commented Nov 29, 2023

Let us merge the commits after the Genode 23.11 release is out of the door.

nfeske pushed a commit to genodelabs/genode that referenced this issue Dec 1, 2023
@cnuke @nfeske
fetchurl: add 'ignore_failures' option
9d989b1 
This option is useful in cases where batching is configured and
failing to fetch a resource should not influence the over-all
result.

Issue genodelabs/genodians.org#32.
@nfeske
Copy link
Member

nfeske commented Dec 1, 2023

Merged cnuke/genode@09ade3c to genode/staging.

nfeske pushed a commit that referenced this issue Dec 1, 2023
@cnuke @nfeske
Be more robust when an author is not available
69da89b 
Treat the case where the genodians archive of given author cannot
be accessed as a mere inconvience (by ignoring this author) rather
than an error that influence the complete appliance (by postponing
new posts by other authors potentially indefinitely).

Issue #32.
@nfeske
Copy link
Member

nfeske commented Dec 1, 2023

I also merged cnuke@6c35da9 to the master branch of genodians.org now.

@cnuke
Copy link
Member Author

cnuke commented Dec 7, 2023

Thanks for merging.

@cnuke cnuke closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cnuke @nfeske