Skip to content

Commit a4e3ad3

Browse files
change check
1 parent d0fcf26 commit a4e3ad3

File tree

4 files changed

+6
-25
lines changed

4 files changed

+6
-25
lines changed

.github/workflows/test-python.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ on:
1010
use-uv:
1111
type: boolean
1212
default: false
13-
description: 'Use `uv` for minimum version resolution'
13+
description: "Use `uv` for minimum version resolution"
1414
coverage:
1515
type: boolean
1616
default: false
17-
description: 'Generate coverage report'
17+
description: "Generate coverage report"
1818

1919
jobs:
2020
check:
@@ -70,11 +70,11 @@ jobs:
7070
- name: Check Formatting
7171
run: |
7272
${{ steps.vars.outputs.VENV_CALL }}
73-
python -m pycodestyle
73+
python -m ruff format --check
7474
- name: Lint code
7575
run: |
7676
${{ steps.vars.outputs.VENV_CALL }}
77-
python -m pylint geoengine
77+
python3 -m ruff check
7878
- name: Type-check code
7979
# mypy seems buggy with uv
8080
if: ${{ !inputs.use-uv }}
@@ -89,10 +89,6 @@ jobs:
8989
run: |
9090
${{ steps.vars.outputs.VENV_CALL }}
9191
${{ steps.vars.outputs.PIP_INSTALL }} -e .[test]
92-
- name: Lint tests
93-
run: |
94-
${{ steps.vars.outputs.VENV_CALL }}
95-
python -m pylint tests
9692
- name: Type-check tests
9793
# mypy seems buggy with uv
9894
if: ${{ !inputs.use-uv }}

check.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ python3 -m ruff format --check
1717

1818
echoerr "Check code with linter"
1919

20-
python3 -m pylint geoengine
21-
python3 -m pylint tests
20+
python3 -m ruff check
2221

2322
echoerr "Check code with type checker"
2423

geoengine/workflow_builder/operators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ def to_dict(self) -> dict[str, Any]:
780780
"expression": self.expression,
781781
"inputColumns": self.input_columns,
782782
"outputColumn": output_column_dict,
783-
} # type: Dict[str, Any]
783+
} # type: dict[str, Any]
784784

785785
if self.geometry_column_name:
786786
params["geometryColumnName"] = self.geometry_column_name

setup.cfg

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)