Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor release while changing minimum supported rust version break dependent crates #1212

Closed
GuillaumeGomez opened this issue Sep 4, 2024 · 4 comments

Comments

@GuillaumeGomez
Copy link
Member

CI build is now broken on geos since last geo-types release since it updated the minimum supported rust version (which is a semver breaking change) while doing a minor release. Could you please yank it and make a release following semver please?

Thanks in advance!

@urschrei
Copy link
Member

urschrei commented Sep 4, 2024

which is a semver breaking change

It is? Where is that documented?

@frewsxcv
Copy link
Member

frewsxcv commented Sep 4, 2024

This is not a breaking change https://doc.rust-lang.org/cargo/reference/semver.html#env-new-rust Bumping a major version of geo_types is a lot of work for maintainers and is done only when we absolutely need to.

@frewsxcv frewsxcv closed this as completed Sep 4, 2024
@GuillaumeGomez
Copy link
Member Author

If it breaks code when updating minor, it's most definitely a semver breaking change.

@lnicola
Copy link
Member

lnicola commented Sep 4, 2024

There are good arguments against counting MSRV bumps as breaking: matklad/once_cell#201 (comment). And it didn't break any code, it broke a particular CI setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants