fix: Add AppmapMiddleware.should_record

Author: symwell

appmap/_implementation/web_framework.py

@@ -135,6 +135,9 @@ def __init__(self):
         self.record_url = "/_appmap/record"
         DetectEnabled.initialize()
 
+    def should_record(self):
+        return DetectEnabled.should_enable("remote") or DetectEnabled.should_enable("requests")
+
     def before_request_hook(self, request, request_path, recording_is_running):
         if request_path == self.record_url:
             return None, None, None

appmap/django.py

@@ -23,7 +23,6 @@
 from django.urls.resolvers import _route_to_regex
 
 from appmap._implementation import generation, recording, web_framework
-from appmap._implementation.detect_enabled import DetectEnabled
 from appmap._implementation.env import Env
 from appmap._implementation.event import (
     ExceptionEvent,
@@ -217,10 +216,7 @@ def __init__(self, get_response):
         self.recorder = Recorder()
 
     def __call__(self, request):
-        if not (
-            DetectEnabled.should_enable("remote")
-            or DetectEnabled.should_enable("requests")
-        ):
+        if not self.should_record():
             return self.get_response(request)
 
         if request.path_info == self.record_url:

appmap/flask.py

@@ -53,10 +53,7 @@ def __init__(self, app=None):
             self.init_app(app)
 
     def init_app(self, app):
-        if not (
-            DetectEnabled.should_enable("remote")
-            or DetectEnabled.should_enable("requests")
-        ):
+        if not self.should_record():
             return
 
         self.recording = Recording()
@@ -85,10 +82,7 @@ def init_app(self, app):
         app.after_request(self.after_request)
 
     def record_get(self):
-        if not (
-            DetectEnabled.should_enable("remote")
-            or DetectEnabled.should_enable("requests")
-        ):
+        if not self.should_record():
             return "Appmap is disabled.", 404
 
         return {"enabled": self.recording.is_running()}
@@ -109,10 +103,7 @@ def record_delete(self):
         return json.loads(generation.dump(self.recording))
 
     def before_request(self):
-        if not (
-            DetectEnabled.should_enable("remote")
-            or DetectEnabled.should_enable("requests")
-        ):
+        if not self.should_record():
             return
 
         rec, start, call_event_id = self.before_request_hook(
@@ -149,10 +140,7 @@ def before_request_main(self, rec, request):
         return None, None
 
     def after_request(self, response):
-        if not (
-            DetectEnabled.should_enable("remote")
-            or DetectEnabled.should_enable("requests")
-        ):
+        if not self.should_record():
             return response
 
         return self.after_request_hook(