fix: if FLASK_DEBUG=0 or FLASK_ENV=production then don't enable

Author: symwell

appmap/_implementation/detect_enabled.py

@@ -91,25 +91,34 @@ def detect_should_enable(cls, recording_method):
 
         # it's flask
         message, should_enable = cls.is_flask_and_should_enable()
-        if should_enable:
+        if should_enable == True or should_enable == False:
             return [message, should_enable]
 
         # it's django
         message, should_enable = cls.is_django_and_should_enable()
-        if should_enable:
+        if should_enable == True or should_enable == False:
             return [message, should_enable]
 
-        return ["it is not enabled by any configuration or framework", False]
+        if recording_method in RECORDING_METHODS:
+            return ["will record by default", True]
+
+        return ["it's not enabled by any configuration or framework", False]
 
     @classmethod
     def is_flask_and_should_enable(cls):
-        if "FLASK_DEBUG" in os.environ and os.environ["FLASK_DEBUG"] == "1":
-            return [f"FLASK_DEBUG={os.environ['FLASK_DEBUG']}", True]
+        if "FLASK_DEBUG" in os.environ:
+            if os.environ["FLASK_DEBUG"] == "1":
+                return [f"FLASK_DEBUG={os.environ['FLASK_DEBUG']}", True]
+            elif os.environ["FLASK_DEBUG"] == "0":
+                return [f"FLASK_DEBUG={os.environ['FLASK_DEBUG']}", False]
 
-        if "FLASK_ENV" in os.environ and os.environ["FLASK_ENV"] == "development":
-            return [f"FLASK_ENV={os.environ['FLASK_ENV']}", True]
+        if "FLASK_ENV" in os.environ:
+            if os.environ["FLASK_ENV"] == "development":
+                return [f"FLASK_ENV={os.environ['FLASK_ENV']}", True]
+            elif os.environ["FLASK_ENV"] == "production":
+                return [f"FLASK_ENV={os.environ['FLASK_ENV']}", False]
 
-        return ["it is not Flask", False]
+        return ["it's not Flask", None]
 
     @classmethod
     def is_django_and_should_enable(cls):
@@ -151,4 +160,4 @@ def is_django_and_should_enable(cls):
                     # it wasn't set. it's ok
                     pass
 
-        return ["it is not Django", False]
+        return ["it's not Django", None]