From de6adc91583c2b89e37e7e978fdfa6347302d289 Mon Sep 17 00:00:00 2001 From: jaoleal Date: Mon, 28 Sep 2026 15:31:32 -0300 Subject: [PATCH 1/2] fix(floresta-build): drop the self-recursive passthru.overrideAttrs passthru shadows the overrideAttrs stdenv.mkDerivation provides, and the one defined here called (mkFloresta args).overrideAttrs, which is itself: every overrideAttrs on a Floresta build recursed forever. --- lib/floresta-build.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/floresta-build.nix b/lib/floresta-build.nix index 29f5ed5..01b0784 100644 --- a/lib/floresta-build.nix +++ b/lib/floresta-build.nix @@ -322,7 +322,6 @@ let passthru = { inherit cfg pkgConfig; override = newArgs: mkFloresta (cfg // newArgs); - overrideAttrs = f: (mkFloresta args).overrideAttrs f; }; } // extraEnvVars From c29d196f18be2434b5cc8d6b009ccd38fa699483 Mon Sep 17 00:00:00 2001 From: jaoleal Date: Mon, 28 Sep 2026 16:46:30 -0300 Subject: [PATCH 2/2] fix(floresta-build): fetch the default source at evaluation time floresta-build reads the version off the source's Cargo.toml, so a fetchFromGitHub defaultSrc is import-from-derivation, and `nix flake check ./examples --no-build` cannot build the fetch. It passes only because the main flake check, earlier in the same CI job, instantiates the identical getfloresta fetch; releases fetched from anywhere else break it. builtins.fetchTarball fetches the same tree (same NAR hash, same store path) while evaluating, with no derivation to build. --- lib/floresta-build.nix | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/floresta-build.nix b/lib/floresta-build.nix index 01b0784..235452a 100644 --- a/lib/floresta-build.nix +++ b/lib/floresta-build.nix @@ -4,12 +4,12 @@ pkgs ? import { }, lib ? pkgs.lib, # Source tree every build defaults to; standalone imports fall back to - # the latest release tag. - defaultSrc ? pkgs.fetchFromGitHub { - owner = "getfloresta"; - repo = "Floresta"; - rev = "v0.9.1"; - hash = "sha256-5dfE0Bd0yCDh7Kc0PsSXjBWLQ9WmNCCbropdXfK9YSk="; + # the v0.9.1 tag. Fetched at evaluation time rather than by a + # derivation: the version is read off its Cargo.toml, and a derivation + # cannot be built under `nix flake check --no-build`. + defaultSrc ? builtins.fetchTarball { + url = "https://github.com/getfloresta/Floresta/archive/v0.9.1.tar.gz"; + sha256 = "sha256-5dfE0Bd0yCDh7Kc0PsSXjBWLQ9WmNCCbropdXfK9YSk="; }, # Extra environment variables set on buildRustPackage (e.g. ANDROID_NDK_HOME) extraEnvVars ? { },